Re: [PATCH 15/16] qapi/expr.py: move related checks inside check_xxx functions

2020-09-24 Thread Cleber Rosa
On Tue, Sep 22, 2020 at 05:13:12PM -0400, John Snow wrote: > There's not a big obvious difference between the types of checks that > happen in the main function versus the kind that happen in the > functions. Now they're in one place for each of the main types. > > As part of the move, spell out

Re: [PATCH 15/16] qapi/expr.py: move related checks inside check_xxx functions

2020-09-24 Thread John Snow
On 9/23/20 4:25 PM, Eduardo Habkost wrote: On Tue, Sep 22, 2020 at 05:13:12PM -0400, John Snow wrote: There's not a big obvious difference between the types of checks that happen in the main function versus the kind that happen in the functions. Now they're in one place for each of the main

Re: [PATCH 15/16] qapi/expr.py: move related checks inside check_xxx functions

2020-09-23 Thread Eduardo Habkost
On Tue, Sep 22, 2020 at 05:13:12PM -0400, John Snow wrote: > There's not a big obvious difference between the types of checks that > happen in the main function versus the kind that happen in the > functions. Now they're in one place for each of the main types. > > As part of the move, spell out

[PATCH 15/16] qapi/expr.py: move related checks inside check_xxx functions

2020-09-22 Thread John Snow
There's not a big obvious difference between the types of checks that happen in the main function versus the kind that happen in the functions. Now they're in one place for each of the main types. As part of the move, spell out the required and optional keywords so they're obvious at a glance.