Re: [PATCH 15/22] hw/sh4: make RTL8139 a hard dependency for RD2

2023-05-03 Thread Paolo Bonzini
On 5/3/23 11:12, Alex Bennée wrote: We can't just imply it as the board will fail to create otherwise. This shows up as a "make check" failure with a --without-default-devices build. Not needed, also typo in subject (should be R2D rather than RD2). Paolo

Re: [PATCH 15/22] hw/sh4: make RTL8139 a hard dependency for RD2

2023-05-03 Thread Richard Henderson
On 5/3/23 10:12, Alex Bennée wrote: We can't just imply it as the board will fail to create otherwise. This shows up as a "make check" failure with a --without-default-devices build. Signed-off-by: Alex Bennée --- hw/sh4/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) Reviewed

[PATCH 15/22] hw/sh4: make RTL8139 a hard dependency for RD2

2023-05-03 Thread Alex Bennée
We can't just imply it as the board will fail to create otherwise. This shows up as a "make check" failure with a --without-default-devices build. Signed-off-by: Alex Bennée --- hw/sh4/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/sh4/Kconfig b/hw/sh4/Kconfig ind