Re: [PATCH 15/52] migration/rdma: Ditch useless numeric error codes in error messages

2023-09-22 Thread Markus Armbruster
"Zhijian Li (Fujitsu)" writes: > On 18/09/2023 22:41, Markus Armbruster wrote: >> Several error messages include numeric error codes returned by failed >> functions: >> >> * ibv_poll_cq() returns an unspecified negative value. Useless. >> >> * rdma_accept and rmda_get_cm_event() return -1. Us

Re: [PATCH 15/52] migration/rdma: Ditch useless numeric error codes in error messages

2023-09-22 Thread Zhijian Li (Fujitsu)
On 18/09/2023 22:41, Markus Armbruster wrote: > Several error messages include numeric error codes returned by failed > functions: > > * ibv_poll_cq() returns an unspecified negative value. Useless. > > * rdma_accept and rmda_get_cm_event() return -1. Useless. s/rmda_get_cm_event/rdma_get_c

Re: [PATCH 15/52] migration/rdma: Ditch useless numeric error codes in error messages

2023-09-18 Thread Fabiano Rosas
Markus Armbruster writes: > Several error messages include numeric error codes returned by failed > functions: > > * ibv_poll_cq() returns an unspecified negative value. Useless. > > * rdma_accept and rmda_get_cm_event() return -1. Useless. > > * qemu_rdma_poll() returns either -1 or an unspeci

[PATCH 15/52] migration/rdma: Ditch useless numeric error codes in error messages

2023-09-18 Thread Markus Armbruster
Several error messages include numeric error codes returned by failed functions: * ibv_poll_cq() returns an unspecified negative value. Useless. * rdma_accept and rmda_get_cm_event() return -1. Useless. * qemu_rdma_poll() returns either -1 or an unspecified negative value. Useless. * qemu_