Re: [PATCH 16/20] hw/block: Factor pflash_cfi02_create() out of pflash_cfi02_register()

2023-01-08 Thread Bin Meng
On Thu, Jan 5, 2023 at 6:51 AM Philippe Mathieu-Daudé wrote: > > Currently pflash_cfi02_register(): > > 1/ creates a TYPE_PFLASH_CFI02 qdev instance > 2/ maps the first MMIO region to the system bus > > The first minor issue is the implicit sysbus mapping is not > obvious (the function name coul

[PATCH 16/20] hw/block: Factor pflash_cfi02_create() out of pflash_cfi02_register()

2023-01-04 Thread Philippe Mathieu-Daudé
Currently pflash_cfi02_register(): 1/ creates a TYPE_PFLASH_CFI02 qdev instance 2/ maps the first MMIO region to the system bus The first minor issue is the implicit sysbus mapping is not obvious (the function name could mention it), and the function is not documented. Another issue is we are