Re: [PATCH 16/22] qapi/parser: add docstrings

2021-05-07 Thread Markus Armbruster
John Snow writes: > On 4/25/21 9:27 AM, Markus Armbruster wrote: >> Another ignorant doc string markup question... how am I supposed to see >> that exprs and docs are attributes, and not global variables? >> > > The syntax is apparently supposed to be :py:attr:`MyClass.attr`. Though, > it does

Re: [PATCH 16/22] qapi/parser: add docstrings

2021-05-06 Thread John Snow
On 4/25/21 9:27 AM, Markus Armbruster wrote: Another ignorant doc string markup question... how am I supposed to see that exprs and docs are attributes, and not global variables? The syntax is apparently supposed to be :py:attr:`MyClass.attr`. Though, it doesn't seem to be working for me. I

Re: [PATCH 16/22] qapi/parser: add docstrings

2021-05-05 Thread John Snow
On 4/27/21 5:03 AM, Markus Armbruster wrote: John Snow writes: On 4/25/21 9:27 AM, Markus Armbruster wrote: John Snow writes: Signed-off-by: John Snow --- My hubris is infinite. Score one of the three principal virtues of a programmer ;) It was written before the prior review, but

Re: [PATCH 16/22] qapi/parser: add docstrings

2021-04-27 Thread Markus Armbruster
John Snow writes: > On 4/25/21 9:27 AM, Markus Armbruster wrote: >> John Snow writes: >> >>> Signed-off-by: John Snow >>> >>> --- >>> >>> My hubris is infinite. >> >> Score one of the three principal virtues of a programmer ;) >> > > It was written before the prior review, but I promise I am

Re: [PATCH 16/22] qapi/parser: add docstrings

2021-04-26 Thread John Snow
On 4/25/21 9:27 AM, Markus Armbruster wrote: John Snow writes: Signed-off-by: John Snow --- My hubris is infinite. Score one of the three principal virtues of a programmer ;) It was written before the prior review, but I promise I am slowing down on adding these. I just genuinely left

Re: [PATCH 16/22] qapi/parser: add docstrings

2021-04-25 Thread Markus Armbruster
John Snow writes: > Signed-off-by: John Snow > > --- > > My hubris is infinite. Score one of the three principal virtues of a programmer ;) > OK, I only added a few -- to help me remember how the parser works at a > glance. > > Signed-off-by: John Snow > --- > scripts/qapi/parser.py | 66 ++

[PATCH 16/22] qapi/parser: add docstrings

2021-04-21 Thread John Snow
Signed-off-by: John Snow --- My hubris is infinite. OK, I only added a few -- to help me remember how the parser works at a glance. Signed-off-by: John Snow --- scripts/qapi/parser.py | 66 ++ 1 file changed, 66 insertions(+) diff --git a/scripts/qapi