On Mon, Sep 21, 2020 at 10:05:24AM +0200, Markus Armbruster wrote:
[...]
> I sense a certain wobbliness in mypy. Perhaps to be expected from a
> tool with major version zero. There's a risk that developers' local
> "make check" and our gating CI differ too much. We'll see.
This possibility
On 9/21/20 4:05 AM, Markus Armbruster wrote:
John Snow writes:
On 9/18/20 7:55 AM, Markus Armbruster wrote:
Ignorant question: why does this come after PATCH 13 "qapi/common.py:
add notational type hints", but before all the other patches adding type
hints?
John Snow writes:
Fix two very
On 9/21/20 4:05 AM, Markus Armbruster wrote:
John Snow writes:
On 9/18/20 7:55 AM, Markus Armbruster wrote:
Ignorant question: why does this come after PATCH 13 "qapi/common.py:
add notational type hints", but before all the other patches adding type
hints?
John Snow writes:
Fix two very
John Snow writes:
> On 9/18/20 7:55 AM, Markus Armbruster wrote:
>> Ignorant question: why does this come after PATCH 13 "qapi/common.py:
>> add notational type hints", but before all the other patches adding type
>> hints?
>> John Snow writes:
>>
>>> Fix two very minor issues, and then
John Snow writes:
> On 9/18/20 7:55 AM, Markus Armbruster wrote:
>> Ignorant question: why does this come after PATCH 13 "qapi/common.py:
>> add notational type hints", but before all the other patches adding type
>> hints?
>> John Snow writes:
>>
>>> Fix two very minor issues, and then
On 9/18/20 7:55 AM, Markus Armbruster wrote:
Ignorant question: why does this come after PATCH 13 "qapi/common.py:
add notational type hints", but before all the other patches adding type
hints?
John Snow writes:
Fix two very minor issues, and then establish a mypy type-checking
baseline.
On 9/18/20 7:55 AM, Markus Armbruster wrote:
Ignorant question: why does this come after PATCH 13 "qapi/common.py:
add notational type hints", but before all the other patches adding type
hints?
John Snow writes:
Fix two very minor issues, and then establish a mypy type-checking
baseline.
Ignorant question: why does this come after PATCH 13 "qapi/common.py:
add notational type hints", but before all the other patches adding type
hints?
John Snow writes:
> Fix two very minor issues, and then establish a mypy type-checking
> baseline.
>
> Like pylint, this should be run from the
Fix two very minor issues, and then establish a mypy type-checking
baseline.
Like pylint, this should be run from the folder above:
> mypy --config-file=qapi/mypy.ini qapi/
Signed-off-by: John Snow
---
scripts/qapi/doc.py| 3 +-
scripts/qapi/mypy.ini | 65
