Re: [PATCH 18/20] xive: Improve irq claim/free path

2019-09-25 Thread David Gibson
On Wed, Sep 25, 2019 at 09:25:47AM +0200, Cédric Le Goater wrote: > On 25/09/2019 08:45, David Gibson wrote: > > spapr_xive_irq_claim() returns a bool to indicate if it succeeded. But > > most of the callers and one callee use a richer Error * instead. So use > > that instead of a bool return so

Re: [PATCH 18/20] xive: Improve irq claim/free path

2019-09-25 Thread Cédric Le Goater
On 25/09/2019 08:45, David Gibson wrote: > spapr_xive_irq_claim() returns a bool to indicate if it succeeded. But > most of the callers and one callee use a richer Error * instead. So use > that instead of a bool return so we can actually pass more informative > errors up the stack. > > In addit

[PATCH 18/20] xive: Improve irq claim/free path

2019-09-25 Thread David Gibson
spapr_xive_irq_claim() returns a bool to indicate if it succeeded. But most of the callers and one callee use a richer Error * instead. So use that instead of a bool return so we can actually pass more informative errors up the stack. In addition it didn't actually check if the irq was already c