Re: [PATCH 2/2] hw/m68k/q800.c: Make the GLUE chip an actual QOM device

2020-11-09 Thread Peter Maydell
On Mon, 9 Nov 2020 at 14:15, Philippe Mathieu-Daudé wrote: > > Hi Peter, > > On 11/7/20 12:51 AM, Peter Maydell wrote: > > The handling of the GLUE (General Logic Unit) device is > > currently open-coded. Make this into a proper QOM device. > > > > This minor piece of modernisation gets rid of the

Re: [PATCH 2/2] hw/m68k/q800.c: Make the GLUE chip an actual QOM device

2020-11-09 Thread Philippe Mathieu-Daudé
Hi Peter, On 11/7/20 12:51 AM, Peter Maydell wrote: > The handling of the GLUE (General Logic Unit) device is > currently open-coded. Make this into a proper QOM device. > > This minor piece of modernisation gets rid of the free > floating qemu_irq array 'pic', which Coverity points out > is tech

Re: [PATCH 2/2] hw/m68k/q800.c: Make the GLUE chip an actual QOM device

2020-11-07 Thread Laurent Vivier
Le 07/11/2020 à 00:51, Peter Maydell a écrit : > The handling of the GLUE (General Logic Unit) device is > currently open-coded. Make this into a proper QOM device. > > This minor piece of modernisation gets rid of the free > floating qemu_irq array 'pic', which Coverity points out > is technicall

[PATCH 2/2] hw/m68k/q800.c: Make the GLUE chip an actual QOM device

2020-11-06 Thread Peter Maydell
The handling of the GLUE (General Logic Unit) device is currently open-coded. Make this into a proper QOM device. This minor piece of modernisation gets rid of the free floating qemu_irq array 'pic', which Coverity points out is technically leaked when we exit the machine init function. (The repla