Re: [PATCH 2/2] hw/misc/allwinner-h3-dramc: enforce 64-bit multiply when calculating row mirror address

2020-03-23 Thread Niek Linnenbank
Hi Peter, On Sun, Mar 22, 2020 at 10:18 PM Peter Maydell wrote: > On Sun, 22 Mar 2020 at 20:54, Niek Linnenbank > wrote: > > > > The allwinner_h3_dramc_map_rows function simulates row addressing > behavior > > when bootloader software attempts to detect the amount of available > SDRAM. > > > >

Re: [PATCH 2/2] hw/misc/allwinner-h3-dramc: enforce 64-bit multiply when calculating row mirror address

2020-03-22 Thread Peter Maydell
On Sun, 22 Mar 2020 at 20:54, Niek Linnenbank wrote: > > The allwinner_h3_dramc_map_rows function simulates row addressing behavior > when bootloader software attempts to detect the amount of available SDRAM. > > Currently the line that calculates the 64-bit address of the mirrored row > uses a si

[PATCH 2/2] hw/misc/allwinner-h3-dramc: enforce 64-bit multiply when calculating row mirror address

2020-03-22 Thread Niek Linnenbank
The allwinner_h3_dramc_map_rows function simulates row addressing behavior when bootloader software attempts to detect the amount of available SDRAM. Currently the line that calculates the 64-bit address of the mirrored row uses a signed 32-bit multiply operation that in theory could result in the