Re: [PATCH 2/2] hw: aspeed: Init all UART's with serial devices

2022-05-16 Thread Peter Maydell
On Fri, 13 May 2022 at 22:09, Peter Delevoryas wrote > I was actually intentionally skipping that. If serial_hd(i) > doesn’t exist, the function will return NULL. > > Chardev *serial_hd(int i) > { > assert(i >= 0); > if (i < num_serial_hds) { > return serial_hds[i]; > } >

Re: [PATCH 2/2] hw: aspeed: Init all UART's with serial devices

2022-05-15 Thread Peter Delevoryas
> On May 15, 2022, at 2:19 PM, Cédric Le Goater wrote: > > [ ... ] > >>> The problem is that it is breaking compatibility with previous QEMUs. >> It is? We can still run things the old way too, I specifically >> wrote this with the intention that it would support backwards >> compatibility. >

Re: [PATCH 2/2] hw: aspeed: Init all UART's with serial devices

2022-05-15 Thread Cédric Le Goater
[ ... ] The problem is that it is breaking compatibility with previous QEMUs. It is? We can still run things the old way too, I specifically wrote this with the intention that it would support backwards compatibility. You are right. Let's start with your patchset. We can add the "uart" machi

Re: [PATCH 2/2] hw: aspeed: Init all UART's with serial devices

2022-05-14 Thread Peter Delevoryas
> On May 14, 2022, at 12:30 AM, Cédric Le Goater wrote: > > On 5/13/22 23:08, Peter Delevoryas wrote: >>> On May 12, 2022, at 10:31 PM, Cédric Le Goater wrote: >>> >>> On 5/13/22 06:02, Peter Delevoryas wrote: Usually, QEMU users just provide one serial device on the command line, e

Re: [PATCH 2/2] hw: aspeed: Init all UART's with serial devices

2022-05-14 Thread Cédric Le Goater
On 5/13/22 23:08, Peter Delevoryas wrote: On May 12, 2022, at 10:31 PM, Cédric Le Goater wrote: On 5/13/22 06:02, Peter Delevoryas wrote: Usually, QEMU users just provide one serial device on the command line, either through "-nographic" or "-serial stdio -display none", or just using VNC a

Re: [PATCH 2/2] hw: aspeed: Init all UART's with serial devices

2022-05-13 Thread Peter Delevoryas
> On May 12, 2022, at 10:31 PM, Cédric Le Goater wrote: > > On 5/13/22 06:02, Peter Delevoryas wrote: >> Usually, QEMU users just provide one serial device on the command line, >> either through "-nographic" or "-serial stdio -display none", or just using >> VNC and popping up a window. We try

Re: [PATCH 2/2] hw: aspeed: Init all UART's with serial devices

2022-05-12 Thread Cédric Le Goater
On 5/13/22 06:02, Peter Delevoryas wrote: Usually, QEMU users just provide one serial device on the command line, either through "-nographic" or "-serial stdio -display none", or just using VNC and popping up a window. We try to match what the user expects, which is to connect the first (and usua

[PATCH 2/2] hw: aspeed: Init all UART's with serial devices

2022-05-12 Thread Peter Delevoryas
Usually, QEMU users just provide one serial device on the command line, either through "-nographic" or "-serial stdio -display none", or just using VNC and popping up a window. We try to match what the user expects, which is to connect the first (and usually only) serial device to the UART a board