Re: [PATCH 2/2] hw: move timer_new from init() into realize() to avoid memleaks

2020-02-15 Thread Philippe Mathieu-Daudé
On 2/15/20 9:37 AM, pannengy...@huawei.com wrote: From: Pan Nengyuan There are some memleaks when we call 'device_list_properties'. This patch move timer_new from init into realize to fix it. Meanwhile, do the null check in mos6522_reset() to avoid null deref if we move timer_new into realize

Re: [PATCH 2/2] hw: move timer_new from init() into realize() to avoid memleaks

2020-02-15 Thread Pan Nengyuan
On 2/15/2020 4:37 PM, pannengy...@huawei.com wrote: I'm sorry for the mail's subject, it's a single patch. [PATCH 2/2] ---> [PATCH] > From: Pan Nengyuan > > There are some memleaks when we call 'device_list_properties'. This patch > move timer_new from init into realize to fix it. > Meanwh

[PATCH 2/2] hw: move timer_new from init() into realize() to avoid memleaks

2020-02-15 Thread pannengyuan
From: Pan Nengyuan There are some memleaks when we call 'device_list_properties'. This patch move timer_new from init into realize to fix it. Meanwhile, do the null check in mos6522_reset() to avoid null deref if we move timer_new into realize(). Reported-by: Euler Robot Signed-off-by: Pan Ne