Re: [PATCH 2/2] migration: Fix return-path thread exit

2024-02-05 Thread Cédric Le Goater
On 2/5/24 04:37, Peter Xu wrote: On Fri, Feb 02, 2024 at 12:11:09PM -0300, Fabiano Rosas wrote: Cédric Le Goater writes: On 2/2/24 15:42, Fabiano Rosas wrote: Cédric Le Goater writes: In case of error, close_return_path_on_source() can perform a shutdown to exit the return-path thread. H

Re: [PATCH 2/2] migration: Fix return-path thread exit

2024-02-04 Thread Peter Xu
On Fri, Feb 02, 2024 at 12:11:09PM -0300, Fabiano Rosas wrote: > Cédric Le Goater writes: > > > On 2/2/24 15:42, Fabiano Rosas wrote: > >> Cédric Le Goater writes: > >> > >>> In case of error, close_return_path_on_source() can perform a shutdown > >>> to exit the return-path thread. However, i

Re: [PATCH 2/2] migration: Fix return-path thread exit

2024-02-02 Thread Fabiano Rosas
Cédric Le Goater writes: > On 2/2/24 15:42, Fabiano Rosas wrote: >> Cédric Le Goater writes: >> >>> In case of error, close_return_path_on_source() can perform a shutdown >>> to exit the return-path thread. However, in migrate_fd_cleanup(), >>> 'to_dst_file' is closed before calling close_retu

Re: [PATCH 2/2] migration: Fix return-path thread exit

2024-02-02 Thread Cédric Le Goater
On 2/2/24 15:42, Fabiano Rosas wrote: Cédric Le Goater writes: In case of error, close_return_path_on_source() can perform a shutdown to exit the return-path thread. However, in migrate_fd_cleanup(), 'to_dst_file' is closed before calling close_return_path_on_source() and the shutdown fails,

Re: [PATCH 2/2] migration: Fix return-path thread exit

2024-02-02 Thread Fabiano Rosas
Cédric Le Goater writes: > In case of error, close_return_path_on_source() can perform a shutdown > to exit the return-path thread. However, in migrate_fd_cleanup(), > 'to_dst_file' is closed before calling close_return_path_on_source() > and the shutdown fails, leaving the source and destinatio

[PATCH 2/2] migration: Fix return-path thread exit

2024-02-01 Thread Cédric Le Goater
In case of error, close_return_path_on_source() can perform a shutdown to exit the return-path thread. However, in migrate_fd_cleanup(), 'to_dst_file' is closed before calling close_return_path_on_source() and the shutdown fails, leaving the source and destination waiting for an event to occur. C