Re: [PATCH 2/2] qemu-iotests: Test convert to qcow2 compressed to NBD

2020-07-27 Thread Nir Soffer
On Mon, Jul 27, 2020 at 1:05 PM Max Reitz wrote: > > On 26.07.20 17:25, Nir Soffer wrote: > > Add test for "qemu-img convert -O qcow2 -c" to NBD target. The use case > > is writing compressed disk content to OVA archive. > > > > Signed-off-by: Nir Soffer > > --- > > tests/qemu-iotests/302 |

Re: [PATCH 2/2] qemu-iotests: Test convert to qcow2 compressed to NBD

2020-07-27 Thread Nir Soffer
On Mon, Jul 27, 2020 at 5:41 PM Eric Blake wrote: > > On 7/27/20 9:35 AM, Nir Soffer wrote: > > >> I guess it's okay that you don't create a real tar file here, but > >> listing the commands to create it (even as a comment) is better than > >> just saying "trust me". And it doesn't seem like

Re: [PATCH 2/2] qemu-iotests: Test convert to qcow2 compressed to NBD

2020-07-27 Thread Eric Blake
On 7/27/20 9:35 AM, Nir Soffer wrote: I guess it's okay that you don't create a real tar file here, but listing the commands to create it (even as a comment) is better than just saying "trust me". And it doesn't seem like that much more work - it looks like the key to your test is that you

Re: [PATCH 2/2] qemu-iotests: Test convert to qcow2 compressed to NBD

2020-07-27 Thread Nir Soffer
On Mon, Jul 27, 2020 at 5:14 PM Eric Blake wrote: > > On 7/27/20 5:04 AM, Max Reitz wrote: > > On 26.07.20 17:25, Nir Soffer wrote: > >> Add test for "qemu-img convert -O qcow2 -c" to NBD target. The use case > >> is writing compressed disk content to OVA archive. > >> > >> Signed-off-by: Nir

Re: [PATCH 2/2] qemu-iotests: Test convert to qcow2 compressed to NBD

2020-07-27 Thread Eric Blake
On 7/27/20 5:04 AM, Max Reitz wrote: On 26.07.20 17:25, Nir Soffer wrote: Add test for "qemu-img convert -O qcow2 -c" to NBD target. The use case is writing compressed disk content to OVA archive. Signed-off-by: Nir Soffer --- +# The use case is writing qcow2 image directly into a tar

Re: [PATCH 2/2] qemu-iotests: Test convert to qcow2 compressed to NBD

2020-07-27 Thread Max Reitz
On 26.07.20 17:25, Nir Soffer wrote: > Add test for "qemu-img convert -O qcow2 -c" to NBD target. The use case > is writing compressed disk content to OVA archive. > > Signed-off-by: Nir Soffer > --- > tests/qemu-iotests/302 | 83 ++ >

[PATCH 2/2] qemu-iotests: Test convert to qcow2 compressed to NBD

2020-07-26 Thread Nir Soffer
Add test for "qemu-img convert -O qcow2 -c" to NBD target. The use case is writing compressed disk content to OVA archive. Signed-off-by: Nir Soffer --- tests/qemu-iotests/302 | 83 ++ tests/qemu-iotests/302.out | 27 +