Re: [PATCH 2/2] qom: Correct error values in two contracts

2020-09-17 Thread Greg Kurz
On Thu, 17 Sep 2020 14:55:40 +0200 Markus Armbruster wrote: > object_property_get_bool()'s contract claims it returns NULL on error. > Pasto; it returns false. > > object_property_get_int()'s contract claims it returns "negative". It > actually returns -1. All the other object_property_get_FOO

Re: [PATCH 2/2] qom: Correct error values in two contracts

2020-09-17 Thread Daniel P . Berrangé
On Thu, Sep 17, 2020 at 02:55:40PM +0200, Markus Armbruster wrote: > object_property_get_bool()'s contract claims it returns NULL on error. > Pasto; it returns false. > > object_property_get_int()'s contract claims it returns "negative". It > actually returns -1. All the other object_property_ge

[PATCH 2/2] qom: Correct error values in two contracts

2020-09-17 Thread Markus Armbruster
object_property_get_bool()'s contract claims it returns NULL on error. Pasto; it returns false. object_property_get_int()'s contract claims it returns "negative". It actually returns -1. All the other object_property_get_FOO() contracts specify the exact error value, so do the same here. Signed