Re: [PATCH 2/2] qom: use correct field name when getting/setting alias properties

2021-07-21 Thread Markus Armbruster
Paolo Bonzini writes: > On 20/07/21 03:00, Eric Blake wrote: >> Deceptively simple; all the work was in the previous patch writing up >> the forwarding visitor. I still wonder if Kevin's QAPI aliases will >> do this more gracefully, but if we're trying to justify this as a bug >> fix worthy of

Re: [PATCH 2/2] qom: use correct field name when getting/setting alias properties

2021-07-21 Thread Paolo Bonzini
On 20/07/21 03:00, Eric Blake wrote: Deceptively simple; all the work was in the previous patch writing up the forwarding visitor. I still wonder if Kevin's QAPI aliases will do this more gracefully, but if we're trying to justify this as a bug fix worthy of 6.1, this is certainly a smaller

Re: [PATCH 2/2] qom: use correct field name when getting/setting alias properties

2021-07-19 Thread Eric Blake
On Mon, Jul 19, 2021 at 12:40:33PM +0200, Paolo Bonzini wrote: > Alias targets have a different name than the alias property itself > (e.g. a machine's pflash0 might be an alias of a property named 'drive'). > When the target's getter or setter invokes the visitor, it will use > a different name

Re: [PATCH 2/2] qom: use correct field name when getting/setting alias properties

2021-07-19 Thread Philippe Mathieu-Daudé
On 7/19/21 12:40 PM, Paolo Bonzini wrote: > Alias targets have a different name than the alias property itself > (e.g. a machine's pflash0 might be an alias of a property named 'drive'). > When the target's getter or setter invokes the visitor, it will use > a different name than what the caller

[PATCH 2/2] qom: use correct field name when getting/setting alias properties

2021-07-19 Thread Paolo Bonzini
Alias targets have a different name than the alias property itself (e.g. a machine's pflash0 might be an alias of a property named 'drive'). When the target's getter or setter invokes the visitor, it will use a different name than what the caller expects, and the visitor will not be able to find