Re: [PATCH 2/2] system/vl.c: parse all -accel options

2024-07-04 Thread Alex Bennée
Paolo Bonzini writes: > On Mon, Jul 1, 2024 at 4:34 PM Philippe Mathieu-Daudé > wrote: >> Reviewed-by: Philippe Mathieu-Daudé > > In principle, a Reviewed-by tag is just stating that you don't know of > any issues that would prevent the patch being included. However, as a > frequent participan

Re: [PATCH 2/2] system/vl.c: parse all -accel options

2024-07-01 Thread Philippe Mathieu-Daudé
On 1/7/24 18:43, Paolo Bonzini wrote: On Mon, Jul 1, 2024 at 4:34 PM Philippe Mathieu-Daudé wrote: Reviewed-by: Philippe Mathieu-Daudé In principle, a Reviewed-by tag is just stating that you don't know of any issues that would prevent the patch being included. However, as a frequent partici

Re: [PATCH 2/2] system/vl.c: parse all -accel options

2024-07-01 Thread Paolo Bonzini
On Mon, Jul 1, 2024 at 4:34 PM Philippe Mathieu-Daudé wrote: > Reviewed-by: Philippe Mathieu-Daudé In principle, a Reviewed-by tag is just stating that you don't know of any issues that would prevent the patch being included. However, as a frequent participant to the project, your Reviewed-by ta

Re: [PATCH 2/2] system/vl.c: parse all -accel options

2024-07-01 Thread Philippe Mathieu-Daudé
On 1/7/24 15:30, Daniel Henrique Barboza wrote: We're not honouring KVM options that are provided by any -accel option aside from the first. In this example: qemu-system-riscv64 -accel kvm,riscv-aia=emul (...) \ -accel kvm,riscv-aia=hwaccel 'riscv-aia' will be set to 'emul', ignoring the last o

[PATCH 2/2] system/vl.c: parse all -accel options

2024-07-01 Thread Daniel Henrique Barboza
We're not honouring KVM options that are provided by any -accel option aside from the first. In this example: qemu-system-riscv64 -accel kvm,riscv-aia=emul (...) \ -accel kvm,riscv-aia=hwaccel 'riscv-aia' will be set to 'emul', ignoring the last occurrence of the option that set 'riscv-aia' to 'h