Re: [PATCH 2/2] tests/9pfs: fix coverity error in create_local_test_dir()

2020-10-30 Thread Christian Schoenebeck
On Freitag, 30. Oktober 2020 13:09:26 CET Peter Maydell wrote: > On Fri, 30 Oct 2020 at 12:02, Christian Schoenebeck > > wrote: > > On Freitag, 30. Oktober 2020 12:44:18 CET Greg Kurz wrote: > > It's not clear to me where this coverity report is accessible online. A > > quick search only brought

Re: [PATCH 2/2] tests/9pfs: fix coverity error in create_local_test_dir()

2020-10-30 Thread Greg Kurz
On Fri, 30 Oct 2020 12:59:48 +0100 Christian Schoenebeck wrote: > On Freitag, 30. Oktober 2020 12:44:18 CET Greg Kurz wrote: > > On Fri, 30 Oct 2020 09:19:46 +0100 > > > > Christian Schoenebeck wrote: > > > Coverity wants the return value of mkdir() to be checked, so let's > > > pretend to do

Re: [PATCH 2/2] tests/9pfs: fix coverity error in create_local_test_dir()

2020-10-30 Thread Peter Maydell
On Fri, 30 Oct 2020 at 12:02, Christian Schoenebeck wrote: > On Freitag, 30. Oktober 2020 12:44:18 CET Greg Kurz wrote: > It's not clear to me where this coverity report is accessible online. A quick > search only brought me to statistics about its latest check, but not the > details of the

Re: [PATCH 2/2] tests/9pfs: fix coverity error in create_local_test_dir()

2020-10-30 Thread Christian Schoenebeck
On Freitag, 30. Oktober 2020 12:44:18 CET Greg Kurz wrote: > On Fri, 30 Oct 2020 09:19:46 +0100 > > Christian Schoenebeck wrote: > > Coverity wants the return value of mkdir() to be checked, so let's > > pretend to do that. We're actually just making a dummy check and > > ignore the result,

Re: [PATCH 2/2] tests/9pfs: fix coverity error in create_local_test_dir()

2020-10-30 Thread Greg Kurz
On Fri, 30 Oct 2020 09:19:46 +0100 Christian Schoenebeck wrote: > Coverity wants the return value of mkdir() to be checked, so let's > pretend to do that. We're actually just making a dummy check and > ignore the result, because we actually only care if the required > directory exists and we

[PATCH 2/2] tests/9pfs: fix coverity error in create_local_test_dir()

2020-10-30 Thread Christian Schoenebeck
Coverity wants the return value of mkdir() to be checked, so let's pretend to do that. We're actually just making a dummy check and ignore the result, because we actually only care if the required directory exists and we have an existence check for that in place already. Reported-by: Greg Kurz