Re: [PATCH 2/3] block/nvme: Use atomic operations instead of 'volatile' keyword

2020-09-17 Thread Stefan Hajnoczi
On Wed, Sep 16, 2020 at 10:40:03PM +0200, Philippe Mathieu-Daudé wrote: I think the current use of volatile is fine. It's widely used in device drivers (see Linux and DPDK) so I'm not sure eliminating it is worthwhile. > Follow docs/devel/atomics.rst guidelines and use atomic operations. > > Cc:

[PATCH 2/3] block/nvme: Use atomic operations instead of 'volatile' keyword

2020-09-16 Thread Philippe Mathieu-Daudé
Follow docs/devel/atomics.rst guidelines and use atomic operations. Cc: Paolo Bonzini Cc: Richard Henderson Cc: Dr. David Alan Gilbert Signed-off-by: Philippe Mathieu-Daudé --- block/nvme.c | 38 -- 1 file changed, 20 insertions(+), 18 deletions(-) diff --