Re: [PATCH 2/3] bsd-user/mmap: use TSA_NO_TSA to suppress clang TSA warnings

2023-01-18 Thread Warner Losh
On Wed, Jan 18, 2023 at 8:12 AM Emanuele Giuseppe Esposito < eespo...@redhat.com> wrote: > > > Am 17/01/2023 um 18:17 schrieb Kevin Wolf: > > Am 17.01.2023 um 17:43 hat Warner Losh geschrieben: > >> On Tue, Jan 17, 2023 at 9:25 AM Kevin Wolf wrote: > >> > >>> Am 17.01.2023 um 17:16 hat Warner Los

Re: [PATCH 2/3] bsd-user/mmap: use TSA_NO_TSA to suppress clang TSA warnings

2023-01-18 Thread Stefan Hajnoczi
On Wed, Jan 18, 2023 at 04:12:09PM +0100, Emanuele Giuseppe Esposito wrote: > > > Am 17/01/2023 um 18:17 schrieb Kevin Wolf: > > Am 17.01.2023 um 17:43 hat Warner Losh geschrieben: > >> On Tue, Jan 17, 2023 at 9:25 AM Kevin Wolf wrote: > >> > >>> Am 17.01.2023 um 17:16 hat Warner Losh geschriebe

Re: [PATCH 2/3] bsd-user/mmap: use TSA_NO_TSA to suppress clang TSA warnings

2023-01-18 Thread Emanuele Giuseppe Esposito
Am 17/01/2023 um 18:17 schrieb Kevin Wolf: > Am 17.01.2023 um 17:43 hat Warner Losh geschrieben: >> On Tue, Jan 17, 2023 at 9:25 AM Kevin Wolf wrote: >> >>> Am 17.01.2023 um 17:16 hat Warner Losh geschrieben: On Tue, Jan 17, 2023 at 6:52 AM Emanuele Giuseppe Esposito < eespo...@redhat

Re: [PATCH 2/3] bsd-user/mmap: use TSA_NO_TSA to suppress clang TSA warnings

2023-01-18 Thread Stefan Hajnoczi
On Wed, Jan 18, 2023, 04:15 Kevin Wolf wrote: > Am 17.01.2023 um 21:43 hat Stefan Hajnoczi geschrieben: > > On Tue, 17 Jan 2023 at 12:17, Kevin Wolf wrote: > > > > > > Am 17.01.2023 um 17:43 hat Warner Losh geschrieben: > > > > On Tue, Jan 17, 2023 at 9:25 AM Kevin Wolf wrote: > > > > > > > > >

Re: [PATCH 2/3] bsd-user/mmap: use TSA_NO_TSA to suppress clang TSA warnings

2023-01-18 Thread Kevin Wolf
Am 17.01.2023 um 21:43 hat Stefan Hajnoczi geschrieben: > On Tue, 17 Jan 2023 at 12:17, Kevin Wolf wrote: > > > > Am 17.01.2023 um 17:43 hat Warner Losh geschrieben: > > > On Tue, Jan 17, 2023 at 9:25 AM Kevin Wolf wrote: > > > > > > > Am 17.01.2023 um 17:16 hat Warner Losh geschrieben: > > > > >

Re: [PATCH 2/3] bsd-user/mmap: use TSA_NO_TSA to suppress clang TSA warnings

2023-01-17 Thread Stefan Hajnoczi
On Tue, 17 Jan 2023 at 12:17, Kevin Wolf wrote: > > Am 17.01.2023 um 17:43 hat Warner Losh geschrieben: > > On Tue, Jan 17, 2023 at 9:25 AM Kevin Wolf wrote: > > > > > Am 17.01.2023 um 17:16 hat Warner Losh geschrieben: > > > > On Tue, Jan 17, 2023 at 6:52 AM Emanuele Giuseppe Esposito < > > > >

Re: [PATCH 2/3] bsd-user/mmap: use TSA_NO_TSA to suppress clang TSA warnings

2023-01-17 Thread Kevin Wolf
Am 17.01.2023 um 17:43 hat Warner Losh geschrieben: > On Tue, Jan 17, 2023 at 9:25 AM Kevin Wolf wrote: > > > Am 17.01.2023 um 17:16 hat Warner Losh geschrieben: > > > On Tue, Jan 17, 2023 at 6:52 AM Emanuele Giuseppe Esposito < > > > eespo...@redhat.com> wrote: > > > > > > > QEMU does not compil

Re: [PATCH 2/3] bsd-user/mmap: use TSA_NO_TSA to suppress clang TSA warnings

2023-01-17 Thread Warner Losh
On Tue, Jan 17, 2023 at 9:25 AM Kevin Wolf wrote: > Am 17.01.2023 um 17:16 hat Warner Losh geschrieben: > > On Tue, Jan 17, 2023 at 6:52 AM Emanuele Giuseppe Esposito < > > eespo...@redhat.com> wrote: > > > > > QEMU does not compile when enabling clang's thread safety analysis > > > (TSA), > > >

Re: [PATCH 2/3] bsd-user/mmap: use TSA_NO_TSA to suppress clang TSA warnings

2023-01-17 Thread Stefan Hajnoczi
On Tue, Jan 17, 2023 at 08:52:02AM -0500, Emanuele Giuseppe Esposito wrote: > QEMU does not compile when enabling clang's thread safety analysis > (TSA), > because some functions create wrappers for pthread mutexes but do > not use any TSA macro. Therefore the compiler fails. > > In order to make

Re: [PATCH 2/3] bsd-user/mmap: use TSA_NO_TSA to suppress clang TSA warnings

2023-01-17 Thread Kevin Wolf
Am 17.01.2023 um 17:16 hat Warner Losh geschrieben: > On Tue, Jan 17, 2023 at 6:52 AM Emanuele Giuseppe Esposito < > eespo...@redhat.com> wrote: > > > QEMU does not compile when enabling clang's thread safety analysis > > (TSA), > > because some functions create wrappers for pthread mutexes but do

Re: [PATCH 2/3] bsd-user/mmap: use TSA_NO_TSA to suppress clang TSA warnings

2023-01-17 Thread Emanuele Giuseppe Esposito
Am 17/01/2023 um 17:16 schrieb Warner Losh: > > > On Tue, Jan 17, 2023 at 6:52 AM Emanuele Giuseppe Esposito > mailto:eespo...@redhat.com>> wrote: > > QEMU does not compile when enabling clang's thread safety analysis > (TSA), > because some functions create wrappers for pthread m

Re: [PATCH 2/3] bsd-user/mmap: use TSA_NO_TSA to suppress clang TSA warnings

2023-01-17 Thread Warner Losh
On Tue, Jan 17, 2023 at 6:52 AM Emanuele Giuseppe Esposito < eespo...@redhat.com> wrote: > QEMU does not compile when enabling clang's thread safety analysis > (TSA), > because some functions create wrappers for pthread mutexes but do > not use any TSA macro. Therefore the compiler fails. > > In o

[PATCH 2/3] bsd-user/mmap: use TSA_NO_TSA to suppress clang TSA warnings

2023-01-17 Thread Emanuele Giuseppe Esposito
QEMU does not compile when enabling clang's thread safety analysis (TSA), because some functions create wrappers for pthread mutexes but do not use any TSA macro. Therefore the compiler fails. In order to make the compiler happy and avoid adding all the necessary macros to all callers (lock functi