Re: [PATCH 2/3] cirrus.yml: Compile macOS and FreeBSD with -Werror

2020-07-28 Thread Daniel P . Berrangé
On Tue, Jul 28, 2020 at 08:43:29AM +0200, Thomas Huth wrote: > On 27/07/2020 12.57, Daniel P. Berrangé wrote: > > On Fri, Jul 24, 2020 at 05:50:47PM +0100, Peter Maydell wrote: > >> On Fri, 24 Jul 2020 at 17:46, Philippe Mathieu-Daudé > >> wrote: > >>> I guess we were expecting the distrib to

Re: [PATCH 2/3] cirrus.yml: Compile macOS and FreeBSD with -Werror

2020-07-28 Thread Thomas Huth
On 27/07/2020 12.57, Daniel P. Berrangé wrote: > On Fri, Jul 24, 2020 at 05:50:47PM +0100, Peter Maydell wrote: >> On Fri, 24 Jul 2020 at 17:46, Philippe Mathieu-Daudé >> wrote: >>> I guess we were expecting the distrib to update the pkg. >> >> Apple's view is that you shouldn't be using the

Re: [PATCH 2/3] cirrus.yml: Compile macOS and FreeBSD with -Werror

2020-07-27 Thread Thomas Huth
On 26/07/2020 18.14, Ed Maste wrote: > On Fri, 24 Jul 2020 at 10:32, Thomas Huth wrote: >> >> Compiler warnings currently go unnoticed in our FreeBSD and macOS builds, >> since -Werror is only enabled for Linux and MinGW builds by default. So >> let's enable them here now, too. > > Reviewed-by:

Re: [PATCH 2/3] cirrus.yml: Compile macOS and FreeBSD with -Werror

2020-07-27 Thread Daniel P . Berrangé
On Fri, Jul 24, 2020 at 05:50:47PM +0100, Peter Maydell wrote: > On Fri, 24 Jul 2020 at 17:46, Philippe Mathieu-Daudé > wrote: > > I guess we were expecting the distrib to update the pkg. > > Apple's view is that you shouldn't be using the sasl header > at all but instead their proprietary

Re: [PATCH 2/3] cirrus.yml: Compile macOS and FreeBSD with -Werror

2020-07-27 Thread Thomas Huth
On 27/07/2020 10.30, Peter Maydell wrote: > On Mon, 27 Jul 2020 at 06:44, Thomas Huth wrote: >> Sounds like it could be done, indeed. But I wonder whether we really >> really want to silence the warnings here? We'd hide the information to >> the users that sasl is apparently disliked by Apple and

Re: [PATCH 2/3] cirrus.yml: Compile macOS and FreeBSD with -Werror

2020-07-27 Thread Peter Maydell
On Mon, 27 Jul 2020 at 06:44, Thomas Huth wrote: > Sounds like it could be done, indeed. But I wonder whether we really > really want to silence the warnings here? We'd hide the information to > the users that sasl is apparently disliked by Apple and might get > removed on macOS in the future. >

Re: [PATCH 2/3] cirrus.yml: Compile macOS and FreeBSD with -Werror

2020-07-26 Thread Thomas Huth
On 24/07/2020 18.49, Daniel P. Berrangé wrote: > On Fri, Jul 24, 2020 at 06:46:23PM +0200, Philippe Mathieu-Daudé wrote: >> On 7/24/20 4:46 PM, Daniel P. Berrangé wrote: >>> On Fri, Jul 24, 2020 at 04:32:19PM +0200, Thomas Huth wrote: Compiler warnings currently go unnoticed in our FreeBSD

Re: [PATCH 2/3] cirrus.yml: Compile macOS and FreeBSD with -Werror

2020-07-26 Thread Christian Schoenebeck
On Sonntag, 26. Juli 2020 18:14:11 CEST Ed Maste wrote: > On Fri, 24 Jul 2020 at 10:32, Thomas Huth wrote: > > Compiler warnings currently go unnoticed in our FreeBSD and macOS builds, > > since -Werror is only enabled for Linux and MinGW builds by default. So > > let's enable them here now, too.

Re: [PATCH 2/3] cirrus.yml: Compile macOS and FreeBSD with -Werror

2020-07-26 Thread Ed Maste
On Fri, 24 Jul 2020 at 10:32, Thomas Huth wrote: > > Compiler warnings currently go unnoticed in our FreeBSD and macOS builds, > since -Werror is only enabled for Linux and MinGW builds by default. So > let's enable them here now, too. Reviewed-by: Ed Maste for the FreeBSD change; I'm

Re: [PATCH 2/3] cirrus.yml: Compile macOS and FreeBSD with -Werror

2020-07-24 Thread Christian Schoenebeck
On Freitag, 24. Juli 2020 18:50:47 CEST Peter Maydell wrote: > On Fri, 24 Jul 2020 at 17:46, Philippe Mathieu-Daudé > wrote: > > I guess we were expecting the distrib to update the pkg. > > Apple's view is that you shouldn't be using the sasl header > at all but instead their proprietary crypto

Re: [PATCH 2/3] cirrus.yml: Compile macOS and FreeBSD with -Werror

2020-07-24 Thread Peter Maydell
On Fri, 24 Jul 2020 at 17:46, Philippe Mathieu-Daudé wrote: > I guess we were expecting the distrib to update the pkg. Apple's view is that you shouldn't be using the sasl header at all but instead their proprietary crypto library APIs, so I wouldn't expect them to ever ship something without

Re: [PATCH 2/3] cirrus.yml: Compile macOS and FreeBSD with -Werror

2020-07-24 Thread Daniel P . Berrangé
On Fri, Jul 24, 2020 at 06:46:23PM +0200, Philippe Mathieu-Daudé wrote: > On 7/24/20 4:46 PM, Daniel P. Berrangé wrote: > > On Fri, Jul 24, 2020 at 04:32:19PM +0200, Thomas Huth wrote: > >> Compiler warnings currently go unnoticed in our FreeBSD and macOS builds, > >> since -Werror is only enabled

Re: [PATCH 2/3] cirrus.yml: Compile macOS and FreeBSD with -Werror

2020-07-24 Thread Philippe Mathieu-Daudé
On 7/24/20 4:46 PM, Daniel P. Berrangé wrote: > On Fri, Jul 24, 2020 at 04:32:19PM +0200, Thomas Huth wrote: >> Compiler warnings currently go unnoticed in our FreeBSD and macOS builds, >> since -Werror is only enabled for Linux and MinGW builds by default. So >> let's enable them here now, too.

Re: [PATCH 2/3] cirrus.yml: Compile macOS and FreeBSD with -Werror

2020-07-24 Thread Peter Maydell
On Fri, 24 Jul 2020 at 15:32, Thomas Huth wrote: > > Compiler warnings currently go unnoticed in our FreeBSD and macOS builds, > since -Werror is only enabled for Linux and MinGW builds by default. So > let's enable them here now, too. > For macOS, that unfortunately means that we have to disable

Re: [PATCH 2/3] cirrus.yml: Compile macOS and FreeBSD with -Werror

2020-07-24 Thread Daniel P . Berrangé
On Fri, Jul 24, 2020 at 04:32:19PM +0200, Thomas Huth wrote: > Compiler warnings currently go unnoticed in our FreeBSD and macOS builds, > since -Werror is only enabled for Linux and MinGW builds by default. So > let's enable them here now, too. > For macOS, that unfortunately means that we have

[PATCH 2/3] cirrus.yml: Compile macOS and FreeBSD with -Werror

2020-07-24 Thread Thomas Huth
Compiler warnings currently go unnoticed in our FreeBSD and macOS builds, since -Werror is only enabled for Linux and MinGW builds by default. So let's enable them here now, too. For macOS, that unfortunately means that we have to disable the vnc-sasl feature, since this is marked as deprecated in