Re: [PATCH 2/3] tests/acceptance/machine_s390_ccw_virtio: Test virtio-rng via /dev/hwrng

2020-12-15 Thread Wainer dos Santos Moschetta
On 12/12/20 4:10 AM, Thomas Huth wrote: On 11/12/2020 21.30, Wainer dos Santos Moschetta wrote: Hi, On 12/11/20 2:31 PM, Thomas Huth wrote: /dev/hwrng is only functional if virtio-rng is working right, so let's add a sanity check for this device node. Good idea. Signed-off-by: Thomas Huth

Re: [PATCH 2/3] tests/acceptance/machine_s390_ccw_virtio: Test virtio-rng via /dev/hwrng

2020-12-14 Thread Cornelia Huck
On Sat, 12 Dec 2020 08:10:01 +0100 Thomas Huth wrote: Minor nit: I think that the subject is a bit unwieldy. What about "tests/acceptance: Test virtio-rng on s390 via /dev/hwrng" ? > On 11/12/2020 21.30, Wainer dos Santos Moschetta wrote: > > Hi, > > > > On 12/11/20 2:31 PM, Thomas Huth wrote

Re: [PATCH 2/3] tests/acceptance/machine_s390_ccw_virtio: Test virtio-rng via /dev/hwrng

2020-12-11 Thread Thomas Huth
On 11/12/2020 21.30, Wainer dos Santos Moschetta wrote: > Hi, > > On 12/11/20 2:31 PM, Thomas Huth wrote: >> /dev/hwrng is only functional if virtio-rng is working right, so let's >> add a sanity check for this device node. > > Good idea. > >> >> Signed-off-by: Thomas Huth >> --- >>   tests/acc

Re: [PATCH 2/3] tests/acceptance/machine_s390_ccw_virtio: Test virtio-rng via /dev/hwrng

2020-12-11 Thread Wainer dos Santos Moschetta
Hi, On 12/11/20 2:31 PM, Thomas Huth wrote: /dev/hwrng is only functional if virtio-rng is working right, so let's add a sanity check for this device node. Good idea. Signed-off-by: Thomas Huth --- tests/acceptance/machine_s390_ccw_virtio.py | 17 +++-- 1 file changed, 15 in

[PATCH 2/3] tests/acceptance/machine_s390_ccw_virtio: Test virtio-rng via /dev/hwrng

2020-12-11 Thread Thomas Huth
/dev/hwrng is only functional if virtio-rng is working right, so let's add a sanity check for this device node. Signed-off-by: Thomas Huth --- tests/acceptance/machine_s390_ccw_virtio.py | 17 +++-- 1 file changed, 15 insertions(+), 2 deletions(-) diff --git a/tests/acceptance/machi