Re: [PATCH 2/4] .gitlab-ci.d/windows.yml: Keep 64-bit and 32-bit build scripts consistent

2022-11-25 Thread Bin Meng
On Fri, Nov 25, 2022 at 6:56 PM Thomas Huth wrote: > > On 25/11/2022 11.49, Bin Meng wrote: > > From: Bin Meng > > > > At present the build scripts of 32-bit and 64-bit are inconsistent. > > Let's keep them consistent for easier maintenance. > > > > While we are here, add some comments to

Re: [PATCH 2/4] .gitlab-ci.d/windows.yml: Keep 64-bit and 32-bit build scripts consistent

2022-11-25 Thread Thomas Huth
On 25/11/2022 11.49, Bin Meng wrote: From: Bin Meng At present the build scripts of 32-bit and 64-bit are inconsistent. Let's keep them consistent for easier maintenance. While we are here, add some comments to explain that for the 64-bit job, "--without-default-devices" is a must have, at

[PATCH 2/4] .gitlab-ci.d/windows.yml: Keep 64-bit and 32-bit build scripts consistent

2022-11-25 Thread Bin Meng
From: Bin Meng At present the build scripts of 32-bit and 64-bit are inconsistent. Let's keep them consistent for easier maintenance. While we are here, add some comments to explain that for the 64-bit job, "--without-default-devices" is a must have, at least for now. Signed-off-by: Bin Meng