Re: [PATCH 2/4] hw/hppa/dino: Fix reg800_keep_bits[] overrun (CID 1419393 & 1419394)

2020-02-17 Thread Philippe Mathieu-Daudé
On Tue, Feb 18, 2020 at 7:19 AM Philippe Mathieu-Daudé wrote: > On Mon, Feb 17, 2020 at 6:37 PM Peter Maydell > wrote: > > On Thu, 13 Feb 2020 at 23:44, Philippe Mathieu-Daudé > > wrote: > > > > > > > Fixes: Covertiy CID 1419393 and 1419394 (commit 18092598a5) > > > Signed-off-by: Philippe

Re: [PATCH 2/4] hw/hppa/dino: Fix reg800_keep_bits[] overrun (CID 1419393 & 1419394)

2020-02-17 Thread Philippe Mathieu-Daudé
On Mon, Feb 17, 2020 at 6:37 PM Peter Maydell wrote: > On Thu, 13 Feb 2020 at 23:44, Philippe Mathieu-Daudé wrote: > > > > Fixes: Covertiy CID 1419393 and 1419394 (commit 18092598a5) > > Signed-off-by: Philippe Mathieu-Daudé > > I think this also fixes CID 1419387 ? Ah I missed this one,

Re: [PATCH 2/4] hw/hppa/dino: Fix reg800_keep_bits[] overrun (CID 1419393 & 1419394)

2020-02-17 Thread Peter Maydell
On Thu, 13 Feb 2020 at 23:44, Philippe Mathieu-Daudé wrote: > Fixes: Covertiy CID 1419393 and 1419394 (commit 18092598a5) > Signed-off-by: Philippe Mathieu-Daudé I think this also fixes CID 1419387 ? thanks -- PMM

Re: [PATCH 2/4] hw/hppa/dino: Fix reg800_keep_bits[] overrun (CID 1419393 & 1419394)

2020-02-15 Thread Helge Deller
On 14.02.20 00:41, Philippe Mathieu-Daudé wrote: > > Fixes: Covertiy CID 1419393 and 1419394 (commit 18092598a5) > Signed-off-by: Philippe Mathieu-Daudé Acked-by: Helge Deller > --- > hw/hppa/dino.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/hw/hppa/dino.c

[PATCH 2/4] hw/hppa/dino: Fix reg800_keep_bits[] overrun (CID 1419393 & 1419394)

2020-02-13 Thread Philippe Mathieu-Daudé
Coverity reports: *** CID 1419393: Memory - corruptions (OVERRUN) /hw/hppa/dino.c: 363 in dino_chip_write_with_attrs() 357 /* These registers are read-only. */ 358 break; 359 360 case DINO_GMASK ... DINO_TLTIM: 361 i = (addr -