Re: [PATCH 2/4] target/ppc: Move VSX vector with length storage access insns to decodetree.

2024-06-09 Thread Richard Henderson
On 6/9/24 11:11, Chinmay Rath wrote: The calculation of effective address in these instructions is slightly different than the others, for which helper function exist : EA for these insns : EA ← (RA=0) ? 0 : GPR[RA] EA for rest storage access insns : EA ← ((RA=0) ? 0 : GPR[RA]) + GPR[RB] This

Re: [PATCH 2/4] target/ppc: Move VSX vector with length storage access insns to decodetree.

2024-06-09 Thread Chinmay Rath
Hi Richard, On 6/7/24 21:11, Richard Henderson wrote: On 6/7/24 07:49, Chinmay Rath wrote: +static bool do_ld_st_vl(DisasContext *ctx, arg_X *a, +    void (*helper)(TCGv_ptr, TCGv, TCGv_ptr, TCGv)) +{ +    TCGv EA; +    TCGv_ptr xt; +    if (a->rt < 32) { +    REQUIRE_

Re: [PATCH 2/4] target/ppc: Move VSX vector with length storage access insns to decodetree.

2024-06-07 Thread Richard Henderson
On 6/7/24 07:49, Chinmay Rath wrote: +static bool do_ld_st_vl(DisasContext *ctx, arg_X *a, +void (*helper)(TCGv_ptr, TCGv, TCGv_ptr, TCGv)) +{ +TCGv EA; +TCGv_ptr xt; +if (a->rt < 32) { +REQUIRE_VSX(ctx); +} else { +REQUIRE_VECTOR(ctx); +

[PATCH 2/4] target/ppc: Move VSX vector with length storage access insns to decodetree.

2024-06-07 Thread Chinmay Rath
Moving the following instructions to decodetree specification : {l, st}xvl(l) : X-form The changes were verified by validating that the tcg-ops generated by those instructions remain the same, which were captured using the '-d in_asm,op' flag. Signed-off-by: Chinmay Rath ---