Re: [PATCH 2/5] s390x: Add loadparm to CcwDevice

2024-06-05 Thread Thomas Huth
On 29/05/2024 17.43, jro...@linux.ibm.com wrote: From: Jared Rossi Add a loadparm property to the CcwDevice object so that different loadparms can be defined on a per-device basis when using multiple boot devices. The machine/global loadparm is still supported. If both a global and per-device

Re: [PATCH 2/5] s390x: Add loadparm to CcwDevice

2024-06-04 Thread Thomas Huth
On 04/06/2024 18.27, Jared Rossi wrote: Hi Thomas, Firstly, thanks for the reviews and I agree with your suggestions about function names, info messages, simplifications, etc...  I will make those changes. As for the DIAG308_FLAGS_LP_VALID flag... [snip...] @@ -438,40 +473,20 @@ static

Re: [PATCH 2/5] s390x: Add loadparm to CcwDevice

2024-06-04 Thread Jared Rossi
Hi Thomas, Firstly, thanks for the reviews and I agree with your suggestions about function names, info messages, simplifications, etc...  I will make those changes. As for the DIAG308_FLAGS_LP_VALID flag... [snip...] @@ -438,40 +473,20 @@ static bool s390_gen_initial_iplb(S390IPLState

Re: [PATCH 2/5] s390x: Add loadparm to CcwDevice

2024-06-04 Thread Thomas Huth
On 29/05/2024 17.43, jro...@linux.ibm.com wrote: From: Jared Rossi Add a loadparm property to the CcwDevice object so that different loadparms can be defined on a per-device basis when using multiple boot devices. The machine/global loadparm is still supported. If both a global and per-device

[PATCH 2/5] s390x: Add loadparm to CcwDevice

2024-05-29 Thread jrossi
From: Jared Rossi Add a loadparm property to the CcwDevice object so that different loadparms can be defined on a per-device basis when using multiple boot devices. The machine/global loadparm is still supported. If both a global and per-device loadparm are defined, the per-device value will