Re: [PATCH 2/5] target/s390x: Do not modify cpu state in s390_cpu_get_psw_mask

2021-06-15 Thread David Hildenbrand
On 15.06.21 05:07, Richard Henderson wrote: We want to use this function for debugging, and debug should not modify cpu state (even non-architectural cpu state) lest we introduce heisenbugs. Signed-off-by: Richard Henderson --- target/s390x/helper.c | 8 1 file changed, 4 insertions

[PATCH 2/5] target/s390x: Do not modify cpu state in s390_cpu_get_psw_mask

2021-06-14 Thread Richard Henderson
We want to use this function for debugging, and debug should not modify cpu state (even non-architectural cpu state) lest we introduce heisenbugs. Signed-off-by: Richard Henderson --- target/s390x/helper.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/target/s390x/h