Re: [PATCH 2/5] vhost: involve device backends in feature negotiation

2020-06-03 Thread Stefan Hajnoczi
On Fri, May 29, 2020 at 03:29:13PM +0100, Dr. David Alan Gilbert wrote: > * Stefan Hajnoczi (stefa...@redhat.com) wrote: > > On Fri, May 29, 2020 at 03:04:54PM +0800, Jason Wang wrote: > > > > > > On 2020/5/23 上午1:17, Stefan Hajnoczi wrote: > > > > Many vhost devices in QEMU currently do not invol

Re: [PATCH 2/5] vhost: involve device backends in feature negotiation

2020-06-03 Thread Stefan Hajnoczi
On Mon, Jun 01, 2020 at 08:51:43PM +0800, Jason Wang wrote: > > On 2020/5/29 下午9:56, Stefan Hajnoczi wrote: > > On Fri, May 29, 2020 at 03:04:54PM +0800, Jason Wang wrote: > > > On 2020/5/23 上午1:17, Stefan Hajnoczi wrote: > > > > Many vhost devices in QEMU currently do not involve the device backe

Re: [PATCH 2/5] vhost: involve device backends in feature negotiation

2020-06-01 Thread Jason Wang
On 2020/5/29 下午9:56, Stefan Hajnoczi wrote: On Fri, May 29, 2020 at 03:04:54PM +0800, Jason Wang wrote: On 2020/5/23 上午1:17, Stefan Hajnoczi wrote: Many vhost devices in QEMU currently do not involve the device backend in feature negotiation. This seems fine at first glance for device types w

Re: [PATCH 2/5] vhost: involve device backends in feature negotiation

2020-05-29 Thread Stefan Hajnoczi
On Wed, May 27, 2020 at 04:28:41PM +0200, Marc-André Lureau wrote: > Hi Stefan > > On Fri, May 22, 2020 at 7:18 PM Stefan Hajnoczi wrote: > > > > Many vhost devices in QEMU currently do not involve the device backend > > in feature negotiation. This seems fine at first glance for device types > >

Re: [PATCH 2/5] vhost: involve device backends in feature negotiation

2020-05-29 Thread Dr. David Alan Gilbert
* Stefan Hajnoczi (stefa...@redhat.com) wrote: > On Fri, May 29, 2020 at 03:04:54PM +0800, Jason Wang wrote: > > > > On 2020/5/23 上午1:17, Stefan Hajnoczi wrote: > > > Many vhost devices in QEMU currently do not involve the device backend > > > in feature negotiation. This seems fine at first glanc

Re: [PATCH 2/5] vhost: involve device backends in feature negotiation

2020-05-29 Thread Stefan Hajnoczi
On Fri, May 29, 2020 at 03:04:54PM +0800, Jason Wang wrote: > > On 2020/5/23 上午1:17, Stefan Hajnoczi wrote: > > Many vhost devices in QEMU currently do not involve the device backend > > in feature negotiation. This seems fine at first glance for device types > > without their own feature bits (vi

Re: [PATCH 2/5] vhost: involve device backends in feature negotiation

2020-05-29 Thread Jason Wang
On 2020/5/23 上午1:17, Stefan Hajnoczi wrote: Many vhost devices in QEMU currently do not involve the device backend in feature negotiation. This seems fine at first glance for device types without their own feature bits (virtio-net has many but other device types have none). This overlooks the

Re: [PATCH 2/5] vhost: involve device backends in feature negotiation

2020-05-27 Thread Marc-André Lureau
Hi Stefan On Fri, May 22, 2020 at 7:18 PM Stefan Hajnoczi wrote: > > Many vhost devices in QEMU currently do not involve the device backend > in feature negotiation. This seems fine at first glance for device types > without their own feature bits (virtio-net has many but other device > types hav

[PATCH 2/5] vhost: involve device backends in feature negotiation

2020-05-22 Thread Stefan Hajnoczi
Many vhost devices in QEMU currently do not involve the device backend in feature negotiation. This seems fine at first glance for device types without their own feature bits (virtio-net has many but other device types have none). This overlooks the fact that QEMU's virtqueue implementation and th