Re: [PATCH 2/6] dp8393x: don't force 32-bit register access

2021-07-04 Thread Mark Cave-Ayland
On 03/07/2021 17:29, Philippe Mathieu-Daudé wrote: On 7/3/21 4:39 PM, Mark Cave-Ayland wrote: On 03/07/2021 15:19, Philippe Mathieu-Daudé wrote: From: Mark Cave-Ayland Commit 3fe9a838ec "dp8393x: Always use 32-bit accesses" assumed that all accesses to the registers were 32-bit but this is

Re: [PATCH 2/6] dp8393x: don't force 32-bit register access

2021-07-03 Thread Finn Thain
On Sat, 3 Jul 2021, Philippe Mathieu-Daudé wrote: > From: Mark Cave-Ayland > > Commit 3fe9a838ec "dp8393x: Always use 32-bit accesses" assumed that all > accesses > to the registers were 32-bit but this is actually not the case. The access > size is > determined by the CPU instruction used an

Re: [PATCH 2/6] dp8393x: don't force 32-bit register access

2021-07-03 Thread Philippe Mathieu-Daudé
On 7/3/21 4:39 PM, Mark Cave-Ayland wrote: > On 03/07/2021 15:19, Philippe Mathieu-Daudé wrote: > >> From: Mark Cave-Ayland >> >> Commit 3fe9a838ec "dp8393x: Always use 32-bit accesses" assumed that >> all accesses >> to the registers were 32-bit but this is actually not the case. The >> access s

Re: [PATCH 2/6] dp8393x: don't force 32-bit register access

2021-07-03 Thread Mark Cave-Ayland
On 03/07/2021 15:19, Philippe Mathieu-Daudé wrote: From: Mark Cave-Ayland Commit 3fe9a838ec "dp8393x: Always use 32-bit accesses" assumed that all accesses to the registers were 32-bit but this is actually not the case. The access size is determined by the CPU instruction used and not the nu

[PATCH 2/6] dp8393x: don't force 32-bit register access

2021-07-03 Thread Philippe Mathieu-Daudé
From: Mark Cave-Ayland Commit 3fe9a838ec "dp8393x: Always use 32-bit accesses" assumed that all accesses to the registers were 32-bit but this is actually not the case. The access size is determined by the CPU instruction used and not the number of physical address lines. The big_endian worka