Re: [PATCH 2/6] hw/arm/exynos4210: Fix DMA initialization

2020-01-17 Thread Peter Maydell
On Fri, 17 Jan 2020 at 18:07, Guenter Roeck wrote: > > Hi Peter, > > On Fri, Jan 17, 2020 at 01:30:19PM +, Peter Maydell wrote: > > On Fri, 10 Jan 2020 at 20:39, Guenter Roeck wrote: > > > > > > First parameter to exynos4210_get_irq() is not the SPI port number, > > > but the interrupt group

Re: [PATCH 2/6] hw/arm/exynos4210: Fix DMA initialization

2020-01-17 Thread Guenter Roeck
Hi Peter, On Fri, Jan 17, 2020 at 01:30:19PM +, Peter Maydell wrote: > On Fri, 10 Jan 2020 at 20:39, Guenter Roeck wrote: > > > > First parameter to exynos4210_get_irq() is not the SPI port number, > > but the interrupt group number. Interrupt groups are 20 for mdma > > and 21 for pdma.

Re: [PATCH 2/6] hw/arm/exynos4210: Fix DMA initialization

2020-01-17 Thread Peter Maydell
On Fri, 10 Jan 2020 at 20:39, Guenter Roeck wrote: > > First parameter to exynos4210_get_irq() is not the SPI port number, > but the interrupt group number. Interrupt groups are 20 for mdma > and 21 for pdma. Interrupts are not inverted. Controllers support 32 > events (pdma) or 31 events (mdma).

[PATCH 2/6] hw/arm/exynos4210: Fix DMA initialization

2020-01-10 Thread Guenter Roeck
First parameter to exynos4210_get_irq() is not the SPI port number, but the interrupt group number. Interrupt groups are 20 for mdma and 21 for pdma. Interrupts are not inverted. Controllers support 32 events (pdma) or 31 events (mdma). Events must all be routed to a single interrupt line. Set