Re: [PATCH 2/6] system/physmem: IOMMU: Invoke the translate_size function if it is implemented

2023-10-31 Thread Ethan Chen via
On Mon, Oct 30, 2023 at 11:02:30AM -0400, Peter Xu wrote: > On Mon, Oct 30, 2023 at 02:00:54PM +0800, Ethan Chen wrote: > > On Fri, Oct 27, 2023 at 12:13:50PM -0400, Peter Xu wrote: > > > Add cc list. > > > > > > On Fri, Oct 27, 2023 at 12:02:24PM -0400, Peter Xu wrote: > > > > On Fri, Oct 27, 202

Re: [PATCH 2/6] system/physmem: IOMMU: Invoke the translate_size function if it is implemented

2023-10-30 Thread Peter Xu
On Mon, Oct 30, 2023 at 02:00:54PM +0800, Ethan Chen wrote: > On Fri, Oct 27, 2023 at 12:13:50PM -0400, Peter Xu wrote: > > Add cc list. > > > > On Fri, Oct 27, 2023 at 12:02:24PM -0400, Peter Xu wrote: > > > On Fri, Oct 27, 2023 at 11:28:36AM +0800, Ethan Chen wrote: > > > > On Thu, Oct 26, 2023

Re: [PATCH 2/6] system/physmem: IOMMU: Invoke the translate_size function if it is implemented

2023-10-29 Thread Ethan Chen via
On Fri, Oct 27, 2023 at 12:13:50PM -0400, Peter Xu wrote: > Add cc list. > > On Fri, Oct 27, 2023 at 12:02:24PM -0400, Peter Xu wrote: > > On Fri, Oct 27, 2023 at 11:28:36AM +0800, Ethan Chen wrote: > > > On Thu, Oct 26, 2023 at 10:20:41AM -0400, Peter Xu wrote: > > > > Could you elaborate why is

Re: [PATCH 2/6] system/physmem: IOMMU: Invoke the translate_size function if it is implemented

2023-10-27 Thread Peter Xu
Add cc list. On Fri, Oct 27, 2023 at 12:02:24PM -0400, Peter Xu wrote: > On Fri, Oct 27, 2023 at 11:28:36AM +0800, Ethan Chen wrote: > > On Thu, Oct 26, 2023 at 10:20:41AM -0400, Peter Xu wrote: > > > Could you elaborate why is that important? In what use case? > > I was not involved in the formu

Re: [PATCH 2/6] system/physmem: IOMMU: Invoke the translate_size function if it is implemented

2023-10-27 Thread Peter Xu
On Fri, Oct 27, 2023 at 11:28:36AM +0800, Ethan Chen wrote: > On Thu, Oct 26, 2023 at 10:20:41AM -0400, Peter Xu wrote: > > Could you elaborate why is that important? In what use case? > I was not involved in the formulation of the IOPMP specification, but I'll try > to explain my perspective. IOP

Re: [PATCH 2/6] system/physmem: IOMMU: Invoke the translate_size function if it is implemented

2023-10-26 Thread Ethan Chen via
On Thu, Oct 26, 2023 at 10:20:41AM -0400, Peter Xu wrote: > Could you elaborate why is that important? In what use case? I was not involved in the formulation of the IOPMP specification, but I'll try to explain my perspective. IOPMP use the same the idea as PMP. "The matching PMP entry must match

Re: [PATCH 2/6] system/physmem: IOMMU: Invoke the translate_size function if it is implemented

2023-10-26 Thread Peter Xu
On Thu, Oct 26, 2023 at 02:48:14PM +0800, Ethan Chen wrote: > My target is to support IOPMP partially hit error. IOPMP checks whole memory > access region is in the same entry. If not, reject the access instead of > modify > the access size. Could you elaborate why is that important? In what us

Re: [PATCH 2/6] system/physmem: IOMMU: Invoke the translate_size function if it is implemented

2023-10-25 Thread Ethan Chen via
On Wed, Oct 25, 2023 at 11:14:42AM -0400, Peter Xu wrote: > On Wed, Oct 25, 2023 at 01:14:26PM +0800, Ethan Chen wrote: > > Signed-off-by: Ethan Chen > > --- > > system/physmem.c | 9 +++-- > > 1 file changed, 7 insertions(+), 2 deletions(-) > > > > diff --git a/system/physmem.c b/system/phy

Re: [PATCH 2/6] system/physmem: IOMMU: Invoke the translate_size function if it is implemented

2023-10-25 Thread Peter Xu
On Wed, Oct 25, 2023 at 01:14:26PM +0800, Ethan Chen wrote: > Signed-off-by: Ethan Chen > --- > system/physmem.c | 9 +++-- > 1 file changed, 7 insertions(+), 2 deletions(-) > > diff --git a/system/physmem.c b/system/physmem.c > index fc2b0fee01..53b6ab735c 100644 > --- a/system/physmem.c >

[PATCH 2/6] system/physmem: IOMMU: Invoke the translate_size function if it is implemented

2023-10-25 Thread Ethan Chen via
Signed-off-by: Ethan Chen --- system/physmem.c | 9 +++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/system/physmem.c b/system/physmem.c index fc2b0fee01..53b6ab735c 100644 --- a/system/physmem.c +++ b/system/physmem.c @@ -432,8 +432,13 @@ static MemoryRegionSection addres