Re: [PATCH 2/8] migration: Add precopy initial data handshake

2023-05-15 Thread Avihai Horon
On 14/05/2023 19:42, Cédric Le Goater wrote: External email: Use caution opening links or attachments Hello Avihai, +static int loadvm_handle_initial_data_enable(MigrationIncomingState *mis) +{ +    InitialDataInfo buf; +    SaveStateEntry *se; +    ssize_t read_size; + +    read_size = qe

Re: [PATCH 2/8] migration: Add precopy initial data handshake

2023-05-14 Thread Cédric Le Goater
Hello Avihai, +static int loadvm_handle_initial_data_enable(MigrationIncomingState *mis) +{ +InitialDataInfo buf; +SaveStateEntry *se; +ssize_t read_size; + +read_size = qemu_get_buffer(mis->from_src_file, (void *)&buf, sizeof(buf)); +if (read_size != sizeof(buf)) { +

Re: [PATCH 2/8] migration: Add precopy initial data handshake

2023-05-10 Thread Avihai Horon
On 10/05/2023 11:40, Juan Quintela wrote: External email: Use caution opening links or attachments Avihai Horon wrote: Add precopy initial data handshake between source and destination upon migration setup. The purpose of the handshake is to notify the destination that precopy initial data

Re: [PATCH 2/8] migration: Add precopy initial data handshake

2023-05-10 Thread Juan Quintela
Avihai Horon wrote: > Add precopy initial data handshake between source and destination upon > migration setup. The purpose of the handshake is to notify the > destination that precopy initial data is used and which migration users > (i.e., SaveStateEntry) are going to use it. > > The handshake is

Re: [PATCH 2/8] migration: Add precopy initial data handshake

2023-05-03 Thread Avihai Horon
On 03/05/2023 1:54, Peter Xu wrote: External email: Use caution opening links or attachments (I've left high level comment in cover letter, but still some quick comments I noticed when reading) On Mon, May 01, 2023 at 05:01:35PM +0300, Avihai Horon wrote: Add precopy initial data handshake

Re: [PATCH 2/8] migration: Add precopy initial data handshake

2023-05-02 Thread Peter Xu
(I've left high level comment in cover letter, but still some quick comments I noticed when reading) On Mon, May 01, 2023 at 05:01:35PM +0300, Avihai Horon wrote: > Add precopy initial data handshake between source and destination upon > migration setup. The purpose of the handshake is to notify t

[PATCH 2/8] migration: Add precopy initial data handshake

2023-05-01 Thread Avihai Horon
Add precopy initial data handshake between source and destination upon migration setup. The purpose of the handshake is to notify the destination that precopy initial data is used and which migration users (i.e., SaveStateEntry) are going to use it. The handshake is done in two levels. First, a ge