Re: [PATCH 2/9] block: Replaced qemu_mutex_lock calls with QEMU_LOCK_GUARD

2021-03-16 Thread Eric Blake
On 3/12/21 4:23 AM, Vladimir Sementsov-Ogievskiy wrote: > 11.03.2021 06:15, Mahmoud Mandour wrote: >> Replaced various qemu_mutex_lock/qemu_mutex_unlock calls with >> lock guard macros (QEMU_LOCK_GUARD() and WITH_QEMU_LOCK_GUARD). >> This slightly simplifies the code by eliminating calls to >>

Re: [PATCH 2/9] block: Replaced qemu_mutex_lock calls with QEMU_LOCK_GUARD

2021-03-15 Thread Vladimir Sementsov-Ogievskiy
13.03.2021 08:51, Mahmoud Mandour wrote: Thank you for the fast review and I'm sorry for the silly and obvious style errors. Unfortunately I did not notice the section on using the checkpatch script in the Contributing page on the wiki before committing. But I assure you that such errors will

Re: [PATCH 2/9] block: Replaced qemu_mutex_lock calls with QEMU_LOCK_GUARD

2021-03-12 Thread Mahmoud Mandour
Thank you for the fast review and I'm sorry for the silly and obvious style errors. Unfortunately I did not notice the section on using the checkpatch script in the Contributing page on the wiki before committing. But I assure you that such errors will not occur again. On Fri, Mar 12, 2021 at

Re: [PATCH 2/9] block: Replaced qemu_mutex_lock calls with QEMU_LOCK_GUARD

2021-03-12 Thread Vladimir Sementsov-Ogievskiy
11.03.2021 06:15, Mahmoud Mandour wrote: Replaced various qemu_mutex_lock/qemu_mutex_unlock calls with lock guard macros (QEMU_LOCK_GUARD() and WITH_QEMU_LOCK_GUARD). This slightly simplifies the code by eliminating calls to qemu_mutex_unlock and eliminates goto paths. Signed-off-by: Mahmoud

[PATCH 2/9] block: Replaced qemu_mutex_lock calls with QEMU_LOCK_GUARD

2021-03-11 Thread Mahmoud Mandour
Replaced various qemu_mutex_lock/qemu_mutex_unlock calls with lock guard macros (QEMU_LOCK_GUARD() and WITH_QEMU_LOCK_GUARD). This slightly simplifies the code by eliminating calls to qemu_mutex_unlock and eliminates goto paths. Signed-off-by: Mahmoud Mandour --- block/curl.c | 13 ++--