Re: [PATCH 20/24] bsd-user/arm/target_arch_signal.h: arm set_sigtramp_args

2021-10-29 Thread Warner Losh
On Thu, Oct 28, 2021 at 4:41 PM Warner Losh wrote: > > > On Thu, Oct 28, 2021 at 11:25 AM Richard Henderson < > richard.hender...@linaro.org> wrote: > >> On 10/19/21 9:44 AM, Warner Losh wrote: >> > +regs->regs[TARGET_REG_PC] = ka->_sa_handler; >> >> Surely there should be some handling of th

Re: [PATCH 20/24] bsd-user/arm/target_arch_signal.h: arm set_sigtramp_args

2021-10-28 Thread Warner Losh
On Thu, Oct 28, 2021 at 11:25 AM Richard Henderson < richard.hender...@linaro.org> wrote: > On 10/19/21 9:44 AM, Warner Losh wrote: > > +regs->regs[TARGET_REG_PC] = ka->_sa_handler; > > Surely there should be some handling of thumb addresses here. > Yes. I've added code to do this, but haven'

Re: [PATCH 20/24] bsd-user/arm/target_arch_signal.h: arm set_sigtramp_args

2021-10-28 Thread Warner Losh
On Thu, Oct 28, 2021 at 11:35 AM Kyle Evans wrote: > On Thu, Oct 28, 2021 at 12:25 PM Richard Henderson > wrote: > > > > On 10/19/21 9:44 AM, Warner Losh wrote: > > > +regs->regs[TARGET_REG_PC] = ka->_sa_handler; > > > > Surely there should be some handling of thumb addresses here. > > > > H

Re: [PATCH 20/24] bsd-user/arm/target_arch_signal.h: arm set_sigtramp_args

2021-10-28 Thread Kyle Evans
On Thu, Oct 28, 2021 at 12:25 PM Richard Henderson wrote: > > On 10/19/21 9:44 AM, Warner Losh wrote: > > +regs->regs[TARGET_REG_PC] = ka->_sa_handler; > > Surely there should be some handling of thumb addresses here. > Honestly, this wouldn't surprise me- we're kind of a thumb landmine. The

Re: [PATCH 20/24] bsd-user/arm/target_arch_signal.h: arm set_sigtramp_args

2021-10-28 Thread Richard Henderson
On 10/19/21 9:44 AM, Warner Losh wrote: +regs->regs[TARGET_REG_PC] = ka->_sa_handler; Surely there should be some handling of thumb addresses here. r~

Re: [PATCH 20/24] bsd-user/arm/target_arch_signal.h: arm set_sigtramp_args

2021-10-26 Thread Kyle Evans
On Tue, Oct 19, 2021 at 11:45 AM Warner Losh wrote: > > Implement set_sigtramp_args to setup the arguments to the sigtramp > calls. > > Signed-off-by: Stacey Son > Signed-off-by: Warner Losh > --- > bsd-user/arm/target_arch_signal.h | 35 +++ > 1 file changed, 35 ins

[PATCH 20/24] bsd-user/arm/target_arch_signal.h: arm set_sigtramp_args

2021-10-19 Thread Warner Losh
Implement set_sigtramp_args to setup the arguments to the sigtramp calls. Signed-off-by: Stacey Son Signed-off-by: Warner Losh --- bsd-user/arm/target_arch_signal.h | 35 +++ 1 file changed, 35 insertions(+) diff --git a/bsd-user/arm/target_arch_signal.h b/bsd-user