Re: [PATCH 22/33] target/mips: Convert MSA 3R instruction format to decodetree (part 1/4)

2021-10-24 Thread Richard Henderson
On 10/24/21 11:57 AM, Philippe Mathieu-Daudé wrote: On 10/24/21 19:52, Richard Henderson wrote: On 10/23/21 2:47 PM, Philippe Mathieu-Daudé wrote: +static bool trans_msa_3r_df(DisasContext *ctx, arg_msa_r *a, +    void (*gen_msa_3r_df)(TCGv_ptr, TCGv_i32, TCGv_i32, +

Re: [PATCH 22/33] target/mips: Convert MSA 3R instruction format to decodetree (part 1/4)

2021-10-24 Thread Philippe Mathieu-Daudé
On 10/24/21 19:52, Richard Henderson wrote: > On 10/23/21 2:47 PM, Philippe Mathieu-Daudé wrote: >> +static bool trans_msa_3r_df(DisasContext *ctx, arg_msa_r *a, >> +    void (*gen_msa_3r_df)(TCGv_ptr, TCGv_i32, >> TCGv_i32, >> +  

Re: [PATCH 22/33] target/mips: Convert MSA 3R instruction format to decodetree (part 1/4)

2021-10-24 Thread Richard Henderson
On 10/23/21 2:47 PM, Philippe Mathieu-Daudé wrote: +static bool trans_msa_3r_df(DisasContext *ctx, arg_msa_r *a, +void (*gen_msa_3r_df)(TCGv_ptr, TCGv_i32, TCGv_i32, + TCGv_i32, TCGv_i32)) +{ +TCGv_i32 tdf = tcg_cons

Re: [PATCH 22/33] target/mips: Convert MSA 3R instruction format to decodetree (part 1/4)

2021-10-24 Thread Richard Henderson
On 10/23/21 2:47 PM, Philippe Mathieu-Daudé wrote: +TCGv_i32 twd = tcg_const_i32(a->wd); +TCGv_i32 tws = tcg_const_i32(a->ws); +TCGv_i32 twt = tcg_const_i32(a->wt); tcg_constant_i32, otherwise, Reviewed-by: Richard Henderson r~

[PATCH 22/33] target/mips: Convert MSA 3R instruction format to decodetree (part 1/4)

2021-10-23 Thread Philippe Mathieu-Daudé
Convert 3-register operations to decodetree. Since the 'data format' field is a constant value, use tcg_constant_i32() instead of a TCG temporary. Signed-off-by: Philippe Mathieu-Daudé --- target/mips/tcg/msa.decode | 6 ++ target/mips/tcg/msa_translate.c | 35 ++--