Re: [PATCH 3/3] intel-iommu: build iova tree during IOMMU translation

2022-12-23 Thread Peter Xu
On Fri, Dec 23, 2022 at 04:02:29PM +0800, Jason Wang wrote: > On Tue, Dec 6, 2022 at 9:58 PM Peter Xu wrote: > > > > On Tue, Dec 06, 2022 at 11:18:03AM +0800, Jason Wang wrote: > > > On Tue, Dec 6, 2022 at 7:19 AM Peter Xu wrote: > > > > > > > > Jason, > > > > > > > > On Mon, Dec 05, 2022 at

Re: [PATCH 3/3] intel-iommu: build iova tree during IOMMU translation

2022-12-23 Thread Jason Wang
On Tue, Dec 6, 2022 at 9:58 PM Peter Xu wrote: > > On Tue, Dec 06, 2022 at 11:18:03AM +0800, Jason Wang wrote: > > On Tue, Dec 6, 2022 at 7:19 AM Peter Xu wrote: > > > > > > Jason, > > > > > > On Mon, Dec 05, 2022 at 12:12:04PM +0800, Jason Wang wrote: > > > > I'm fine to go without iova-tree.

Re: [PATCH 3/3] intel-iommu: build iova tree during IOMMU translation

2022-12-06 Thread Peter Xu
On Tue, Dec 06, 2022 at 11:18:03AM +0800, Jason Wang wrote: > On Tue, Dec 6, 2022 at 7:19 AM Peter Xu wrote: > > > > Jason, > > > > On Mon, Dec 05, 2022 at 12:12:04PM +0800, Jason Wang wrote: > > > I'm fine to go without iova-tree. Would you mind to post patches for > > > fix? I can test and

Re: [PATCH 3/3] intel-iommu: build iova tree during IOMMU translation

2022-12-05 Thread Jason Wang
On Tue, Dec 6, 2022 at 7:19 AM Peter Xu wrote: > > Jason, > > On Mon, Dec 05, 2022 at 12:12:04PM +0800, Jason Wang wrote: > > I'm fine to go without iova-tree. Would you mind to post patches for > > fix? I can test and include it in this series then. > > One sample patch attached, only compile

Re: [PATCH 3/3] intel-iommu: build iova tree during IOMMU translation

2022-12-05 Thread Peter Xu
Jason, On Mon, Dec 05, 2022 at 12:12:04PM +0800, Jason Wang wrote: > I'm fine to go without iova-tree. Would you mind to post patches for > fix? I can test and include it in this series then. One sample patch attached, only compile tested. I can also work on this but I'll be slow in making

Re: [PATCH 3/3] intel-iommu: build iova tree during IOMMU translation

2022-12-04 Thread Jason Wang
` On Thu, Dec 1, 2022 at 10:59 PM Peter Xu wrote: > > On Thu, Dec 01, 2022 at 04:35:48PM +0800, Jason Wang wrote: > > On Wed, Nov 30, 2022 at 11:17 PM Peter Xu wrote: > > > > > > On Wed, Nov 30, 2022 at 02:33:51PM +0800, Jason Wang wrote: > > > > On Tue, Nov 29, 2022 at 11:57 PM Peter Xu

Re: [PATCH 3/3] intel-iommu: build iova tree during IOMMU translation

2022-12-01 Thread Peter Xu
On Thu, Dec 01, 2022 at 04:35:48PM +0800, Jason Wang wrote: > On Wed, Nov 30, 2022 at 11:17 PM Peter Xu wrote: > > > > On Wed, Nov 30, 2022 at 02:33:51PM +0800, Jason Wang wrote: > > > On Tue, Nov 29, 2022 at 11:57 PM Peter Xu wrote: > > > > > > > > On Tue, Nov 29, 2022 at 04:10:37PM +0800,

Re: [PATCH 3/3] intel-iommu: build iova tree during IOMMU translation

2022-12-01 Thread Jason Wang
On Wed, Nov 30, 2022 at 11:17 PM Peter Xu wrote: > > On Wed, Nov 30, 2022 at 02:33:51PM +0800, Jason Wang wrote: > > On Tue, Nov 29, 2022 at 11:57 PM Peter Xu wrote: > > > > > > On Tue, Nov 29, 2022 at 04:10:37PM +0800, Jason Wang wrote: > > > > The IOVA tree is only built during page walk this

Re: [PATCH 3/3] intel-iommu: build iova tree during IOMMU translation

2022-11-30 Thread Peter Xu
On Wed, Nov 30, 2022 at 02:33:51PM +0800, Jason Wang wrote: > On Tue, Nov 29, 2022 at 11:57 PM Peter Xu wrote: > > > > On Tue, Nov 29, 2022 at 04:10:37PM +0800, Jason Wang wrote: > > > The IOVA tree is only built during page walk this breaks the device > > > that tries to use UNMAP notifier only.

Re: [PATCH 3/3] intel-iommu: build iova tree during IOMMU translation

2022-11-29 Thread Jason Wang
On Tue, Nov 29, 2022 at 11:57 PM Peter Xu wrote: > > On Tue, Nov 29, 2022 at 04:10:37PM +0800, Jason Wang wrote: > > The IOVA tree is only built during page walk this breaks the device > > that tries to use UNMAP notifier only. One example is vhost-net, it > > tries to use UNMAP notifier when

Re: [PATCH 3/3] intel-iommu: build iova tree during IOMMU translation

2022-11-29 Thread Peter Xu
On Tue, Nov 29, 2022 at 04:10:37PM +0800, Jason Wang wrote: > The IOVA tree is only built during page walk this breaks the device > that tries to use UNMAP notifier only. One example is vhost-net, it > tries to use UNMAP notifier when vIOMMU doesn't support DEVIOTLB_UNMAP > notifier (e.g when dt

[PATCH 3/3] intel-iommu: build iova tree during IOMMU translation

2022-11-29 Thread Jason Wang
The IOVA tree is only built during page walk this breaks the device that tries to use UNMAP notifier only. One example is vhost-net, it tries to use UNMAP notifier when vIOMMU doesn't support DEVIOTLB_UNMAP notifier (e.g when dt mode is not enabled). The interesting part is that it doesn't use MAP