Re: [PATCH 3/3] meson: Disable CONFIG_NOTIFY1 on FreeBSD

2024-02-05 Thread Kyle Evans
On 2/5/24 09:31, Daniel P. Berrangé wrote: On Mon, Feb 05, 2024 at 08:23:41AM -0700, Warner Losh wrote: On Wed, Jan 31, 2024 at 9:42 AM Daniel P. Berrangé wrote: On Wed, Jan 31, 2024 at 05:24:10PM +0100, Philippe Mathieu-Daudé wrote: > [... snip ...] On 25/1/24 20:48, Ilya Leoshkevich

Re: [PATCH 3/3] meson: Disable CONFIG_NOTIFY1 on FreeBSD

2024-02-05 Thread Ilya Leoshkevich
On Mon, 2024-02-05 at 15:31 +, Daniel P. Berrangé wrote: > On Mon, Feb 05, 2024 at 08:23:41AM -0700, Warner Losh wrote: > > On Wed, Jan 31, 2024 at 9:42 AM Daniel P. Berrangé > > > > wrote: > > > > > On Wed, Jan 31, 2024 at 05:24:10PM +0100, Philippe Mathieu-Daudé > > > wrote: > > > > Hi, >

Re: [PATCH 3/3] meson: Disable CONFIG_NOTIFY1 on FreeBSD

2024-02-05 Thread Daniel P . Berrangé
On Mon, Feb 05, 2024 at 08:23:41AM -0700, Warner Losh wrote: > On Wed, Jan 31, 2024 at 9:42 AM Daniel P. Berrangé > wrote: > > > On Wed, Jan 31, 2024 at 05:24:10PM +0100, Philippe Mathieu-Daudé wrote: > > > Hi, > > > > > > Warner, do you remember what this is about? > > > > > > ( > >

Re: [PATCH 3/3] meson: Disable CONFIG_NOTIFY1 on FreeBSD

2024-02-05 Thread Warner Losh
On Wed, Jan 31, 2024 at 9:42 AM Daniel P. Berrangé wrote: > On Wed, Jan 31, 2024 at 05:24:10PM +0100, Philippe Mathieu-Daudé wrote: > > Hi, > > > > Warner, do you remember what this is about? > > > > ( >

Re: [PATCH 3/3] meson: Disable CONFIG_NOTIFY1 on FreeBSD

2024-01-31 Thread Daniel P . Berrangé
On Wed, Jan 31, 2024 at 05:24:10PM +0100, Philippe Mathieu-Daudé wrote: > Hi, > > Warner, do you remember what this is about? > > (https://cgit.freebsd.org/ports/commit/emulators/qemu-devel/files/patch-util_meson.build?id=2ab482e2c8f51eae7ffd747685b7f181fe1b3809 > isn't very verbose). That's

Re: [PATCH 3/3] meson: Disable CONFIG_NOTIFY1 on FreeBSD

2024-01-31 Thread Philippe Mathieu-Daudé
Hi, Warner, do you remember what this is about? (https://cgit.freebsd.org/ports/commit/emulators/qemu-devel/files/patch-util_meson.build?id=2ab482e2c8f51eae7ffd747685b7f181fe1b3809 isn't very verbose). On 25/1/24 20:48, Ilya Leoshkevich wrote: make vm-build-freebsd fails with: ld:

Re: [PATCH 3/3] meson: Disable CONFIG_NOTIFY1 on FreeBSD

2024-01-31 Thread Thomas Huth
On 25/01/2024 20.48, Ilya Leoshkevich wrote: make vm-build-freebsd fails with: ld: error: undefined symbol: inotify_init1 >>> referenced by filemonitor-inotify.c:183 (../src/util/filemonitor-inotify.c:183) >>> util_filemonitor-inotify.c.o:(qemu_file_monitor_new) in

[PATCH 3/3] meson: Disable CONFIG_NOTIFY1 on FreeBSD

2024-01-25 Thread Ilya Leoshkevich
make vm-build-freebsd fails with: ld: error: undefined symbol: inotify_init1 >>> referenced by filemonitor-inotify.c:183 (../src/util/filemonitor-inotify.c:183) >>> util_filemonitor-inotify.c.o:(qemu_file_monitor_new) in archive libqemuutil.a On FreeBSD inotify