Re: [PATCH 3/3] qemu-timer: reuse MIN macro in qemu_timeout_ns_to_ms

2019-10-24 Thread Eric Blake
On 10/24/19 1:11 PM, Laurent Vivier wrote: Le 24/10/2019 à 20:03, Eric Blake a écrit : On 10/24/19 12:31 PM, Laurent Vivier wrote: Le 23/10/2019 à 14:26, Frediano Ziglio a écrit : Signed-off-by: Frediano Ziglio ---   util/qemu-timer.c | 6 +-   1 file changed, 1 insertion(+), 5

Re: [PATCH 3/3] qemu-timer: reuse MIN macro in qemu_timeout_ns_to_ms

2019-10-24 Thread Laurent Vivier
Le 24/10/2019 à 20:03, Eric Blake a écrit : > On 10/24/19 12:31 PM, Laurent Vivier wrote: >> Le 23/10/2019 à 14:26, Frediano Ziglio a écrit : >>> Signed-off-by: Frediano Ziglio >>> --- >>>   util/qemu-timer.c | 6 +- >>>   1 file changed, 1 insertion(+), 5 deletions(-) >>> > >>> >> >> Applied

Re: [PATCH 3/3] qemu-timer: reuse MIN macro in qemu_timeout_ns_to_ms

2019-10-24 Thread Laurent Vivier
Le 23/10/2019 à 14:26, Frediano Ziglio a écrit : > Signed-off-by: Frediano Ziglio > --- > util/qemu-timer.c | 6 +- > 1 file changed, 1 insertion(+), 5 deletions(-) > > diff --git a/util/qemu-timer.c b/util/qemu-timer.c > index d428fec567..094a20a05a 100644 > --- a/util/qemu-timer.c > +++

Re: [PATCH 3/3] qemu-timer: reuse MIN macro in qemu_timeout_ns_to_ms

2019-10-24 Thread Eric Blake
On 10/24/19 12:31 PM, Laurent Vivier wrote: Le 23/10/2019 à 14:26, Frediano Ziglio a écrit : Signed-off-by: Frediano Ziglio --- util/qemu-timer.c | 6 +- 1 file changed, 1 insertion(+), 5 deletions(-) Applied to my trivial-patches branch. I've updated the patch to remove the two

Re: [PATCH 3/3] qemu-timer: reuse MIN macro in qemu_timeout_ns_to_ms

2019-10-23 Thread Laurent Vivier
Le 23/10/2019 à 16:51, Eric Blake a écrit : > On 10/23/19 9:45 AM, Laurent Vivier wrote: > >>> The C rules for ternary type promotion guarantee that the MIN macro >>> produces the correct type without the cast ('cond ? int64_t : int32_t' >>> produces int64_t). >> >> gdb seems to disagree with

Re: [PATCH 3/3] qemu-timer: reuse MIN macro in qemu_timeout_ns_to_ms

2019-10-23 Thread Eric Blake
On 10/23/19 9:45 AM, Laurent Vivier wrote: The C rules for ternary type promotion guarantee that the MIN macro produces the correct type without the cast ('cond ? int64_t : int32_t' produces int64_t). gdb seems to disagree with that: (gdb) whatis l type = long long (gdb) whatis i type = int

Re: [PATCH 3/3] qemu-timer: reuse MIN macro in qemu_timeout_ns_to_ms

2019-10-23 Thread Laurent Vivier
Le 23/10/2019 à 16:23, Eric Blake a écrit : > On 10/23/19 9:15 AM, Frediano Ziglio wrote: >>> >>> On 10/23/19 8:42 AM, Laurent Vivier wrote: Le 23/10/2019 à 14:26, Frediano Ziglio a écrit : > Signed-off-by: Frediano Ziglio > --- >    util/qemu-timer.c | 6 +- >    1 file

Re: [PATCH 3/3] qemu-timer: reuse MIN macro in qemu_timeout_ns_to_ms

2019-10-23 Thread Eric Blake
On 10/23/19 9:15 AM, Frediano Ziglio wrote: On 10/23/19 8:42 AM, Laurent Vivier wrote: Le 23/10/2019 à 14:26, Frediano Ziglio a écrit : Signed-off-by: Frediano Ziglio --- util/qemu-timer.c | 6 +- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/util/qemu-timer.c

Re: [PATCH 3/3] qemu-timer: reuse MIN macro in qemu_timeout_ns_to_ms

2019-10-23 Thread Frediano Ziglio
> > On 10/23/19 8:42 AM, Laurent Vivier wrote: > > Le 23/10/2019 à 14:26, Frediano Ziglio a écrit : > >> Signed-off-by: Frediano Ziglio > >> --- > >> util/qemu-timer.c | 6 +- > >> 1 file changed, 1 insertion(+), 5 deletions(-) > >> > >> diff --git a/util/qemu-timer.c b/util/qemu-timer.c

Re: [PATCH 3/3] qemu-timer: reuse MIN macro in qemu_timeout_ns_to_ms

2019-10-23 Thread Eric Blake
On 10/23/19 8:42 AM, Laurent Vivier wrote: Le 23/10/2019 à 14:26, Frediano Ziglio a écrit : Signed-off-by: Frediano Ziglio --- util/qemu-timer.c | 6 +- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/util/qemu-timer.c b/util/qemu-timer.c index d428fec567..094a20a05a 100644

Re: [PATCH 3/3] qemu-timer: reuse MIN macro in qemu_timeout_ns_to_ms

2019-10-23 Thread Laurent Vivier
Le 23/10/2019 à 14:26, Frediano Ziglio a écrit : > Signed-off-by: Frediano Ziglio > --- > util/qemu-timer.c | 6 +- > 1 file changed, 1 insertion(+), 5 deletions(-) > > diff --git a/util/qemu-timer.c b/util/qemu-timer.c > index d428fec567..094a20a05a 100644 > --- a/util/qemu-timer.c > +++

[PATCH 3/3] qemu-timer: reuse MIN macro in qemu_timeout_ns_to_ms

2019-10-23 Thread Frediano Ziglio
Signed-off-by: Frediano Ziglio --- util/qemu-timer.c | 6 +- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/util/qemu-timer.c b/util/qemu-timer.c index d428fec567..094a20a05a 100644 --- a/util/qemu-timer.c +++ b/util/qemu-timer.c @@ -322,11 +322,7 @@ int