Re: [PATCH 3/3] scripts/performance: Add perf_top_25.py script

2020-06-18 Thread Aleksandar Markovic
среда, 17. јун 2020., Ahmed Karaman је написао/ла: > On Wed, Jun 17, 2020 at 7:35 PM Alex Bennée > wrote: > > > > Right - which I do as a developer. It would be rude to sudo things if > > you don't need to because then you end up running your potentially > > un-trusted application with root priv

Re: [PATCH 3/3] scripts/performance: Add perf_top_25.py script

2020-06-17 Thread Ahmed Karaman
On Wed, Jun 17, 2020 at 7:35 PM Alex Bennée wrote: > > Right - which I do as a developer. It would be rude to sudo things if > you don't need to because then you end up running your potentially > un-trusted application with root privileges. > > Could we either probe for the requirement or require

Re: [PATCH 3/3] scripts/performance: Add perf_top_25.py script

2020-06-17 Thread Alex Bennée
Ahmed Karaman writes: > On Wed, Jun 17, 2020 at 2:21 PM Alex Bennée wrote: > >> > + >> > +# Run perf repcord and report >> > +os.system('sudo perf record {} {} 2> /dev/null \ >> > +&& sudo perf report --stdio > tmp.perf.data' >> > + .format(qemu_path, executable)) >> >> Wh

Re: [PATCH 3/3] scripts/performance: Add perf_top_25.py script

2020-06-17 Thread Ahmed Karaman
On Wed, Jun 17, 2020 at 2:21 PM Alex Bennée wrote: > > + > > +# Run perf repcord and report > > +os.system('sudo perf record {} {} 2> /dev/null \ > > +&& sudo perf report --stdio > tmp.perf.data' > > + .format(qemu_path, executable)) > > Why sudo? This is the default require

Re: [PATCH 3/3] scripts/performance: Add perf_top_25.py script

2020-06-17 Thread Alex Bennée
Ahmed Karaman writes: > Python script that prints the top 25 most executed functions in QEMU > using perf. > > Signed-off-by: Ahmed Karaman > --- > scripts/performance/perf_top_25.py | 82 ++ > 1 file changed, 82 insertions(+) > create mode 100644 scripts/performa

Re: [PATCH 3/3] scripts/performance: Add perf_top_25.py script

2020-06-16 Thread Aleksandar Markovic
среда, 17. јун 2020., Ahmed Karaman је написао/ла: > Python script that prints the top 25 most executed functions in QEMU > using perf. > > Signed-off-by: Ahmed Karaman > --- The same comment as I made for patch 2, apply here too. Thanks, Aleksandar > scripts/performance/perf_top_25.py |

[PATCH 3/3] scripts/performance: Add perf_top_25.py script

2020-06-16 Thread Ahmed Karaman
Python script that prints the top 25 most executed functions in QEMU using perf. Signed-off-by: Ahmed Karaman --- scripts/performance/perf_top_25.py | 82 ++ 1 file changed, 82 insertions(+) create mode 100644 scripts/performance/perf_top_25.py diff --git a/scripts/