Re: [PATCH 3/3] target/arm: Determine final stage 2 output PA space based on original IPA

2022-03-31 Thread Peter Maydell
On Tue, 29 Mar 2022 at 20:09, Richard Henderson wrote: > > On 3/27/22 03:34, Idan Horowitz wrote: > > As per the AArch64.S2Walk() psuedo-code in the ARMv8 ARM, the final > > decision as to the output address's PA space based on the SA/SW/NSA/NSA > > bits needs to take the input IPA's PA space

Re: [PATCH 3/3] target/arm: Determine final stage 2 output PA space based on original IPA

2022-03-29 Thread Idan Horowitz
On Tue, 29 Mar 2022 at 22:09, Richard Henderson wrote: > > I believe I follow: because the walk uses walkstate.address.paddress.paspace, > the ipa > input parameter is unchanged, and it is ipa that is passed to > AArch64.S2NextWalkStateLast() to form the output address. > Indeed, I initially

Re: [PATCH 3/3] target/arm: Determine final stage 2 output PA space based on original IPA

2022-03-29 Thread Richard Henderson
On 3/27/22 03:34, Idan Horowitz wrote: As per the AArch64.S2Walk() psuedo-code in the ARMv8 ARM, the final decision as to the output address's PA space based on the SA/SW/NSA/NSA bits needs to take the input IPA's PA space into account, and not the PA space of the result of the stage 2 walk

[PATCH 3/3] target/arm: Determine final stage 2 output PA space based on original IPA

2022-03-27 Thread Idan Horowitz
As per the AArch64.S2Walk() psuedo-code in the ARMv8 ARM, the final decision as to the output address's PA space based on the SA/SW/NSA/NSA bits needs to take the input IPA's PA space into account, and not the PA space of the result of the stage 2 walk itself. Signed-off-by: Idan Horowitz ---