Re: [PATCH 3/4] Allow tests to be disabled

2024-01-17 Thread Alex Bennée
Manolo de Medici writes: > I agree with you, I mentioned that this was the "minimal effort" > patchset to get qemu compilable. > > On Wed, Jan 17, 2024 at 6:35 PM Peter Maydell > wrote: > [...] >> should be guarded by a suitable check that means we don't >> try to build it on hosts that don't h

Re: [PATCH 3/4] Allow tests to be disabled

2024-01-17 Thread Manolo de Medici
I agree with you, I mentioned that this was the "minimal effort" patchset to get qemu compilable. On Wed, Jan 17, 2024 at 6:35 PM Peter Maydell wrote: [...] > should be guarded by a suitable check that means we don't > try to build it on hosts that don't have the host-specific > functions/whateve

Re: [PATCH 3/4] Allow tests to be disabled

2024-01-17 Thread Peter Maydell
On Wed, 17 Jan 2024 at 12:59, Manolo de Medici wrote: > > tests/qtest/tpm-* compilation is not disabled by disable-tpm, > for this reason compilation fails on systems that doesn't > support the linux/bsd TPM api. Fix this by allowing tests > to be disabled. This isn't the right way to fix this. E

Re: [PATCH 3/4] Allow tests to be disabled

2024-01-17 Thread Manolo de Medici
The current patch misses this bit. diff --git a/meson_options.txt b/meson_options.txt index 0a99a059ec..9a2acd6f83 100644 --- a/meson_options.txt +++ b/meson_options.txt @@ -305,6 +305,8 @@ option('libvduse', type: 'feature', value: 'auto', description: 'build VDUSE Library') option('vdus

[PATCH 3/4] Allow tests to be disabled

2024-01-17 Thread Manolo de Medici
tests/qtest/tpm-* compilation is not disabled by disable-tpm, for this reason compilation fails on systems that doesn't support the linux/bsd TPM api. Fix this by allowing tests to be disabled. Signed-off-by: Manolo de Medici --- configure | 7 +++ 1 file changed, 7 insertions(+) diff --git

[PATCH 3/4] Allow tests to be disabled

2024-01-17 Thread Manolo de Medici
tests/qtest/tpm-* compilation is not disabled by disable-tpm, for this reason compilation fails on systems that doesn't support the linux/bsd TPM api. Fix this by allowing tests to be disabled. Signed-off-by: Manolo de Medici --- configure | 7 +++ 1 file changed, 7 insertions(+) diff --git