Re: [PATCH 3/4] target/s390x: Fix LAALG not updating cc_src

2023-10-31 Thread Richard Henderson
On 10/30/23 22:32, Ilya Leoshkevich wrote: LAALG uses op_laa() and cout_addu64(). The latter expects cc_src to be set, but the former does not do it. This can lead to assertion failures if something sets cc_src to neither 0 nor 1 before. Fix by setting cc_src in op_laa(). Fixes: 4dba4d6fef61 ("

[PATCH 3/4] target/s390x: Fix LAALG not updating cc_src

2023-10-30 Thread Ilya Leoshkevich
LAALG uses op_laa() and cout_addu64(). The latter expects cc_src to be set, but the former does not do it. This can lead to assertion failures if something sets cc_src to neither 0 nor 1 before. Fix by setting cc_src in op_laa(). Fixes: 4dba4d6fef61 ("target/s390x: Use atomic operations for LOAD