Re: [PATCH 3/5] target/i386/gdbstub: Factor out gdb_get_reg() and gdb_write_reg()

2024-09-08 Thread Richard Henderson
On 8/2/24 02:59, Ilya Leoshkevich wrote: @@ -248,6 +253,22 @@ static int x86_cpu_gdb_load_seg(X86CPU *cpu, X86Seg sreg, uint8_t *mem_buf) return 4; } +static int gdb_write_reg(CPUX86State *env, uint8_t *mem_buf, target_ulong *val) +{ +if (TARGET_LONG_BITS == 64) { +if (en

[PATCH 3/5] target/i386/gdbstub: Factor out gdb_get_reg() and gdb_write_reg()

2024-08-02 Thread Ilya Leoshkevich
i386 gdbstub handles both i386 and x86_64. Factor out two functions for reading and writing registers without knowing their bitness. Signed-off-by: Ilya Leoshkevich --- target/i386/gdbstub.c | 52 ++- 1 file changed, 31 insertions(+), 21 deletions(-) diff