Re: [PATCH 3/6] block/file-posix: Do not force-cap *pnum

2021-06-21 Thread Max Reitz
On 18.06.21 22:16, Eric Blake wrote: On Thu, Jun 17, 2021 at 05:52:44PM +0200, Max Reitz wrote: bdrv_co_block_status() does it for us, we do not need to do it here. The advantage of not capping *pnum is that bdrv_co_block_status() can cache larger data regions than requested by its caller. We

Re: [PATCH 3/6] block/file-posix: Do not force-cap *pnum

2021-06-19 Thread Vladimir Sementsov-Ogievskiy
17.06.2021 18:52, Max Reitz wrote: bdrv_co_block_status() does it for us, we do not need to do it here. The advantage of not capping *pnum is that bdrv_co_block_status() can cache larger data regions than requested by its caller. Signed-off-by: Max Reitz Reviewed-by: Vladimir Sementsov-Ogievs

Re: [PATCH 3/6] block/file-posix: Do not force-cap *pnum

2021-06-18 Thread Eric Blake
On Thu, Jun 17, 2021 at 05:52:44PM +0200, Max Reitz wrote: > bdrv_co_block_status() does it for us, we do not need to do it here. > > The advantage of not capping *pnum is that bdrv_co_block_status() can > cache larger data regions than requested by its caller. We should update the documentation

[PATCH 3/6] block/file-posix: Do not force-cap *pnum

2021-06-17 Thread Max Reitz
bdrv_co_block_status() does it for us, we do not need to do it here. The advantage of not capping *pnum is that bdrv_co_block_status() can cache larger data regions than requested by its caller. Signed-off-by: Max Reitz --- block/file-posix.c | 7 --- 1 file changed, 4 insertions(+), 3 dele