Re: [PATCH 3/6] target/ppc: Don't initialize some local variables in ppc_radix64_xlate()

2020-05-11 Thread Greg Kurz
On Mon, 11 May 2020 11:07:06 +0200 Cédric Le Goater wrote: > On 5/7/20 7:26 PM, Greg Kurz wrote: > > It is the job of the ppc_radix64_get_fully_qualified_addr() function > > which is called at the beginning of ppc_radix64_xlate() to set both > > lpid *and* pid. It doesn't buy us anything to

Re: [PATCH 3/6] target/ppc: Don't initialize some local variables in ppc_radix64_xlate()

2020-05-11 Thread Cédric Le Goater
On 5/7/20 7:26 PM, Greg Kurz wrote: > It is the job of the ppc_radix64_get_fully_qualified_addr() function > which is called at the beginning of ppc_radix64_xlate() to set both > lpid *and* pid. It doesn't buy us anything to initialize them first. > > Worse, a bug in

[PATCH 3/6] target/ppc: Don't initialize some local variables in ppc_radix64_xlate()

2020-05-07 Thread Greg Kurz
It is the job of the ppc_radix64_get_fully_qualified_addr() function which is called at the beginning of ppc_radix64_xlate() to set both lpid *and* pid. It doesn't buy us anything to initialize them first. Worse, a bug in ppc_radix64_get_fully_qualified_addr(), eg. failing to set either lpid or