Re: [PATCH 3/7] target/i386: Use tcg_gen_ext_tl

2023-10-22 Thread Paolo Bonzini
Il dom 22 ott 2023, 03:29 Richard Henderson ha scritto: > > static TCGv gen_ext_tl(TCGv dst, TCGv src, MemOp size, bool sign) > > { > > -if (memop_size(size) == TARGET_LONG_BITS) { > > +if (size == MO_TL) { > > Yep. > > > I can add it in my x86 series if desirable ... > > That's

Re: [PATCH 3/7] target/i386: Use tcg_gen_ext_tl

2023-10-21 Thread Richard Henderson
On 10/21/23 00:59, Paolo Bonzini wrote: On 10/19/23 23:57, Philippe Mathieu-Daudé wrote: On 19/10/23 20:29, Richard Henderson wrote: -    default: +    if (memop_size(size) == TARGET_LONG_BITS) {   return src;   } Any opinions about adding something like this on top?

Re: [PATCH 3/7] target/i386: Use tcg_gen_ext_tl

2023-10-21 Thread Paolo Bonzini
On 10/19/23 23:57, Philippe Mathieu-Daudé wrote: On 19/10/23 20:29, Richard Henderson wrote: -    default: +    if (memop_size(size) == TARGET_LONG_BITS) {   return src;   } Any opinions about adding something like this on top? - 8<

Re: [PATCH 3/7] target/i386: Use tcg_gen_ext_tl

2023-10-19 Thread Philippe Mathieu-Daudé
On 19/10/23 20:29, Richard Henderson wrote: Signed-off-by: Richard Henderson --- target/i386/tcg/translate.c | 28 +++- 1 file changed, 3 insertions(+), 25 deletions(-) diff --git a/target/i386/tcg/translate.c b/target/i386/tcg/translate.c index

[PATCH 3/7] target/i386: Use tcg_gen_ext_tl

2023-10-19 Thread Richard Henderson
Signed-off-by: Richard Henderson --- target/i386/tcg/translate.c | 28 +++- 1 file changed, 3 insertions(+), 25 deletions(-) diff --git a/target/i386/tcg/translate.c b/target/i386/tcg/translate.c index 0c81e066de..d420ed8f0a 100644 --- a/target/i386/tcg/translate.c +++