Re: [PATCH 3/8] tests/acceptance/linux_ssh_mips_malta.py: drop identical setUp

2021-04-19 Thread Wainer dos Santos Moschetta
On 4/16/21 2:46 PM, Philippe Mathieu-Daudé wrote: On 4/16/21 5:43 PM, Cleber Rosa wrote: On Fri, Apr 16, 2021 at 07:26:05AM +0200, Philippe Mathieu-Daudé wrote: On 4/15/21 11:51 PM, Cleber Rosa wrote: These tests' setUp do not do anything beyong what their base class do. And while they do

Re: [PATCH 3/8] tests/acceptance/linux_ssh_mips_malta.py: drop identical setUp

2021-04-16 Thread Philippe Mathieu-Daudé
On 4/16/21 5:43 PM, Cleber Rosa wrote: > On Fri, Apr 16, 2021 at 07:26:05AM +0200, Philippe Mathieu-Daudé wrote: >> On 4/15/21 11:51 PM, Cleber Rosa wrote: >>> These tests' setUp do not do anything beyong what their base class do. >>> And while they do decorate the setUp() we can decorate the

Re: [PATCH 3/8] tests/acceptance/linux_ssh_mips_malta.py: drop identical setUp

2021-04-16 Thread Cleber Rosa
On Fri, Apr 16, 2021 at 07:26:05AM +0200, Philippe Mathieu-Daudé wrote: > On 4/15/21 11:51 PM, Cleber Rosa wrote: > > These tests' setUp do not do anything beyong what their base class do. > > And while they do decorate the setUp() we can decorate the classes > > instead, so no functionality is

Re: [PATCH 3/8] tests/acceptance/linux_ssh_mips_malta.py: drop identical setUp

2021-04-16 Thread Willian Rampazzo
On Fri, Apr 16, 2021 at 2:26 AM Philippe Mathieu-Daudé wrote: > > On 4/15/21 11:51 PM, Cleber Rosa wrote: > > These tests' setUp do not do anything beyong what their base class do. > > And while they do decorate the setUp() we can decorate the classes > > instead, so no functionality is lost

Re: [PATCH 3/8] tests/acceptance/linux_ssh_mips_malta.py: drop identical setUp

2021-04-16 Thread Willian Rampazzo
On Thu, Apr 15, 2021 at 6:52 PM Cleber Rosa wrote: > > These tests' setUp do not do anything beyong what their base class do. > And while they do decorate the setUp() we can decorate the classes > instead, so no functionality is lost here. > > Signed-off-by: Cleber Rosa > --- >

Re: [PATCH 3/8] tests/acceptance/linux_ssh_mips_malta.py: drop identical setUp

2021-04-15 Thread Philippe Mathieu-Daudé
On 4/15/21 11:51 PM, Cleber Rosa wrote: > These tests' setUp do not do anything beyong what their base class do. > And while they do decorate the setUp() we can decorate the classes > instead, so no functionality is lost here. This is what I did first when adding this test, but it was not

[PATCH 3/8] tests/acceptance/linux_ssh_mips_malta.py: drop identical setUp

2021-04-15 Thread Cleber Rosa
These tests' setUp do not do anything beyong what their base class do. And while they do decorate the setUp() we can decorate the classes instead, so no functionality is lost here. Signed-off-by: Cleber Rosa --- tests/acceptance/linux_ssh_mips_malta.py | 7 ++- 1 file changed, 2