Re: [PATCH 4/4] via-ide: Avoid using isa_get_irq()

2021-10-18 Thread BALATON Zoltan
Hello, On Mon, 18 Oct 2021, Gerd Hoffmann wrote: Hi, I can do that but waiting for a decision on how to proceed. Will Gerd take my first series this is based on as is then this should be a separate series doing the clean up using pci_get_function_0 or should these two series be merged? I'd al

Re: [PATCH 4/4] via-ide: Avoid using isa_get_irq()

2021-10-17 Thread Gerd Hoffmann
Hi, > > I can do that but waiting for a decision on how to proceed. Will Gerd > > take my first series this is based on as is then this should be a > > separate series doing the clean up using pci_get_function_0 or should > > these two series be merged? I'd also squash setting user_creatable = >

Re: [PATCH 4/4] via-ide: Avoid using isa_get_irq()

2021-10-17 Thread BALATON Zoltan
On Sun, 17 Oct 2021, Philippe Mathieu-Daudé wrote: On 10/17/21 20:44, BALATON Zoltan wrote: On Sun, 17 Oct 2021, Philippe Mathieu-Daudé wrote: On 10/15/21 03:06, BALATON Zoltan wrote: Use via_isa_set_irq() which better encapsulates irq handling in the vt82xx model and avoids using isa_get_irq(

Re: [PATCH 4/4] via-ide: Avoid using isa_get_irq()

2021-10-17 Thread BALATON Zoltan
On Sun, 17 Oct 2021, Philippe Mathieu-Daudé wrote: On 10/17/21 21:39, BALATON Zoltan wrote: On Sun, 17 Oct 2021, Philippe Mathieu-Daudé wrote: On 10/15/21 03:06, BALATON Zoltan wrote: Use via_isa_set_irq() which better encapsulates irq handling in the vt82xx model and avoids using isa_get_irq(

Re: [PATCH 4/4] via-ide: Avoid using isa_get_irq()

2021-10-17 Thread Philippe Mathieu-Daudé
On 10/17/21 20:44, BALATON Zoltan wrote: > On Sun, 17 Oct 2021, Philippe Mathieu-Daudé wrote: >> On 10/15/21 03:06, BALATON Zoltan wrote: >>> Use via_isa_set_irq() which better encapsulates irq handling in the >>> vt82xx model and avoids using isa_get_irq() that has a comment saying >>> it should n

Re: [PATCH 4/4] via-ide: Avoid using isa_get_irq()

2021-10-17 Thread Philippe Mathieu-Daudé
On 10/17/21 21:39, BALATON Zoltan wrote: > On Sun, 17 Oct 2021, Philippe Mathieu-Daudé wrote: >> On 10/15/21 03:06, BALATON Zoltan wrote: >>> Use via_isa_set_irq() which better encapsulates irq handling in the >>> vt82xx model and avoids using isa_get_irq() that has a comment saying >>> it should n

Re: [PATCH 4/4] via-ide: Avoid using isa_get_irq()

2021-10-17 Thread BALATON Zoltan
On Sun, 17 Oct 2021, Philippe Mathieu-Daudé wrote: On 10/15/21 03:06, BALATON Zoltan wrote: Use via_isa_set_irq() which better encapsulates irq handling in the vt82xx model and avoids using isa_get_irq() that has a comment saying it should not be used. Signed-off-by: BALATON Zoltan --- hw/ide

Re: [PATCH 4/4] via-ide: Avoid using isa_get_irq()

2021-10-17 Thread BALATON Zoltan
On Sun, 17 Oct 2021, Philippe Mathieu-Daudé wrote: On 10/15/21 03:06, BALATON Zoltan wrote: Use via_isa_set_irq() which better encapsulates irq handling in the vt82xx model and avoids using isa_get_irq() that has a comment saying it should not be used. Signed-off-by: BALATON Zoltan --- hw/ide

Re: [PATCH 4/4] via-ide: Avoid using isa_get_irq()

2021-10-17 Thread Philippe Mathieu-Daudé
On 10/15/21 03:06, BALATON Zoltan wrote: > Use via_isa_set_irq() which better encapsulates irq handling in the > vt82xx model and avoids using isa_get_irq() that has a comment saying > it should not be used. > > Signed-off-by: BALATON Zoltan > --- > hw/ide/via.c | 4 ++-- > 1 file changed, 2 ins

[PATCH 4/4] via-ide: Avoid using isa_get_irq()

2021-10-14 Thread BALATON Zoltan
Use via_isa_set_irq() which better encapsulates irq handling in the vt82xx model and avoids using isa_get_irq() that has a comment saying it should not be used. Signed-off-by: BALATON Zoltan --- hw/ide/via.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/hw/ide/via.c b/h