Re: [PATCH 4/5] hw/xen: Fix double-free in xen_console store_con_info()

2023-04-17 Thread Paul Durrant
On 12/04/2023 19:51, David Woodhouse wrote: From: David Woodhouse Coverity spotted a double-free (CID 1508254); we g_string_free(path) and then for some reason immediately call free(path) too. We should just use g_autoptr() for it anyway, which simplifies the code a bit. Fixes: 7a8a749da7d3 (

Re: [PATCH 4/5] hw/xen: Fix double-free in xen_console store_con_info()

2023-04-12 Thread Peter Maydell
On Wed, 12 Apr 2023 at 19:52, David Woodhouse wrote: > > From: David Woodhouse > > Coverity spotted a double-free (CID 1508254); we g_string_free(path) and > then for some reason immediately call free(path) too. > > We should just use g_autoptr() for it anyway, which simplifies the code > a bit.

[PATCH 4/5] hw/xen: Fix double-free in xen_console store_con_info()

2023-04-12 Thread David Woodhouse
From: David Woodhouse Coverity spotted a double-free (CID 1508254); we g_string_free(path) and then for some reason immediately call free(path) too. We should just use g_autoptr() for it anyway, which simplifies the code a bit. Fixes: 7a8a749da7d3 ("hw/xen: Move xenstore_store_pv_console_info t