Re: [PATCH 4/7] target/arm/kvm: spe: Unify device attr operatioin helper

2020-08-10 Thread Haibo Xu
On Mon, 10 Aug 2020 at 18:29, Andrew Jones wrote: > > On Mon, Aug 10, 2020 at 10:48:41AM +0800, Haibo Xu wrote: > > On Fri, 7 Aug 2020 at 16:19, Philippe Mathieu-Daudé wrote: > > > > > > On 8/7/20 10:10 AM, Haibo Xu wrote: > > > > Rename kvm_arm_pmu_set_attr() to kvm_arm_dev_set_attr(), > > > > >

Re: [PATCH 4/7] target/arm/kvm: spe: Unify device attr operatioin helper

2020-08-10 Thread Andrew Jones
On Mon, Aug 10, 2020 at 10:48:41AM +0800, Haibo Xu wrote: > On Fri, 7 Aug 2020 at 16:19, Philippe Mathieu-Daudé wrote: > > > > On 8/7/20 10:10 AM, Haibo Xu wrote: > > > Rename kvm_arm_pmu_set_attr() to kvm_arm_dev_set_attr(), > > > > Maybe rename kvm_arm_device_set_attr() to match the structure >

Re: [PATCH 4/7] target/arm/kvm: spe: Unify device attr operatioin helper

2020-08-09 Thread Haibo Xu
On Fri, 7 Aug 2020 at 16:19, Philippe Mathieu-Daudé wrote: > > On 8/7/20 10:10 AM, Haibo Xu wrote: > > Rename kvm_arm_pmu_set_attr() to kvm_arm_dev_set_attr(), > > Maybe rename kvm_arm_device_set_attr() to match the structure > name? > Thanks for the review! I will update it in the next version.

Re: [PATCH 4/7] target/arm/kvm: spe: Unify device attr operatioin helper

2020-08-07 Thread Philippe Mathieu-Daudé
On 8/7/20 10:10 AM, Haibo Xu wrote: > Rename kvm_arm_pmu_set_attr() to kvm_arm_dev_set_attr(), Maybe rename kvm_arm_device_set_attr() to match the structure name? > So both the vPMU and vSPE device can share the same API. > > Signed-off-by: Haibo Xu Regardless, with the typo "operation" in pat

[PATCH 4/7] target/arm/kvm: spe: Unify device attr operatioin helper

2020-08-07 Thread Haibo Xu
Rename kvm_arm_pmu_set_attr() to kvm_arm_dev_set_attr(), So both the vPMU and vSPE device can share the same API. Signed-off-by: Haibo Xu --- target/arm/kvm64.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/target/arm/kvm64.c b/target/arm/kvm64.c index 1169237905..75a