Re: [PATCH 49/51] io/channel-watch: Fix socket watch on Windows

2022-10-17 Thread Daniel P . Berrangé
On Mon, Oct 17, 2022 at 09:03:15PM +0800, Bin Meng wrote: > On Mon, Oct 17, 2022 at 8:30 PM Daniel P. Berrangé > wrote: > > > > On Mon, Oct 17, 2022 at 08:21:37PM +0800, Bin Meng wrote: > > > +more people > > > > > > On Tue, Oct 11, 2022 at 6:42 PM Bin Meng wrote: > > > > > > > > Hi Paolo, > > >

Re: [PATCH 49/51] io/channel-watch: Fix socket watch on Windows

2022-10-17 Thread Bin Meng
On Mon, Oct 17, 2022 at 8:30 PM Daniel P. Berrangé wrote: > > On Mon, Oct 17, 2022 at 08:21:37PM +0800, Bin Meng wrote: > > +more people > > > > On Tue, Oct 11, 2022 at 6:42 PM Bin Meng wrote: > > > > > > Hi Paolo, > > > > > > On Thu, Oct 6, 2022 at 11:03 AM Bin Meng wrote: > > > > > > > > Hi Pa

Re: [PATCH 49/51] io/channel-watch: Fix socket watch on Windows

2022-10-17 Thread Daniel P . Berrangé
On Wed, Aug 24, 2022 at 05:40:27PM +0800, Bin Meng wrote: > From: Bin Meng > > Random failure was observed when running qtests on Windows due to > "Broken pipe" detected by qmp_fd_receive(). What happened is that > the qtest executable sends testing data over a socket to the QEMU > under test but

Re: [PATCH 49/51] io/channel-watch: Fix socket watch on Windows

2022-10-17 Thread Daniel P . Berrangé
On Mon, Oct 17, 2022 at 08:21:37PM +0800, Bin Meng wrote: > +more people > > On Tue, Oct 11, 2022 at 6:42 PM Bin Meng wrote: > > > > Hi Paolo, > > > > On Thu, Oct 6, 2022 at 11:03 AM Bin Meng wrote: > > > > > > Hi Paolo, > > > > > > On Wed, Sep 28, 2022 at 2:10 PM Bin Meng wrote: > > > > > > >

Re: [PATCH 49/51] io/channel-watch: Fix socket watch on Windows

2022-10-17 Thread Bin Meng
+more people On Tue, Oct 11, 2022 at 6:42 PM Bin Meng wrote: > > Hi Paolo, > > On Thu, Oct 6, 2022 at 11:03 AM Bin Meng wrote: > > > > Hi Paolo, > > > > On Wed, Sep 28, 2022 at 2:10 PM Bin Meng wrote: > > > > > > Hi Paolo, > > > > > > On Wed, Sep 21, 2022 at 9:02 AM Bin Meng wrote: > > > > > >

Re: [PATCH 49/51] io/channel-watch: Fix socket watch on Windows

2022-10-11 Thread Bin Meng
Hi Paolo, On Thu, Oct 6, 2022 at 11:03 AM Bin Meng wrote: > > Hi Paolo, > > On Wed, Sep 28, 2022 at 2:10 PM Bin Meng wrote: > > > > Hi Paolo, > > > > On Wed, Sep 21, 2022 at 9:02 AM Bin Meng wrote: > > > > > > On Wed, Sep 14, 2022 at 4:08 PM Bin Meng wrote: > > > > > > > > On Wed, Sep 7, 2022

Re: [PATCH 49/51] io/channel-watch: Fix socket watch on Windows

2022-10-05 Thread Bin Meng
Hi Paolo, On Wed, Sep 28, 2022 at 2:10 PM Bin Meng wrote: > > Hi Paolo, > > On Wed, Sep 21, 2022 at 9:02 AM Bin Meng wrote: > > > > On Wed, Sep 14, 2022 at 4:08 PM Bin Meng wrote: > > > > > > On Wed, Sep 7, 2022 at 1:07 PM Bin Meng wrote: > > > > > > > > Hi Clément, > > > > > > > > On Tue, Sep

Re: [PATCH 49/51] io/channel-watch: Fix socket watch on Windows

2022-09-27 Thread Bin Meng
Hi Paolo, On Wed, Sep 21, 2022 at 9:02 AM Bin Meng wrote: > > On Wed, Sep 14, 2022 at 4:08 PM Bin Meng wrote: > > > > On Wed, Sep 7, 2022 at 1:07 PM Bin Meng wrote: > > > > > > Hi Clément, > > > > > > On Tue, Sep 6, 2022 at 8:06 PM Clément Chigot wrote: > > > > > > > > > > > I checked your pat

Re: [PATCH 49/51] io/channel-watch: Fix socket watch on Windows

2022-09-20 Thread Bin Meng
On Wed, Sep 14, 2022 at 4:08 PM Bin Meng wrote: > > On Wed, Sep 7, 2022 at 1:07 PM Bin Meng wrote: > > > > Hi Clément, > > > > On Tue, Sep 6, 2022 at 8:06 PM Clément Chigot wrote: > > > > > > > > > I checked your patch, what you did seems to be something one would > > > > > > naturally write, bu

Re: [PATCH 49/51] io/channel-watch: Fix socket watch on Windows

2022-09-14 Thread Bin Meng
On Wed, Sep 7, 2022 at 1:07 PM Bin Meng wrote: > > Hi Clément, > > On Tue, Sep 6, 2022 at 8:06 PM Clément Chigot wrote: > > > > > > > I checked your patch, what you did seems to be something one would > > > > > naturally write, but what is currently in the QEMU sources seems to be > > > > > writt

Re: [PATCH 49/51] io/channel-watch: Fix socket watch on Windows

2022-09-06 Thread Bin Meng
Hi Clément, On Tue, Sep 6, 2022 at 8:06 PM Clément Chigot wrote: > > > > > I checked your patch, what you did seems to be something one would > > > > naturally write, but what is currently in the QEMU sources seems to be > > > > written intentionally. > > > > > > > > +Paolo Bonzini , you are the

Re: [PATCH 49/51] io/channel-watch: Fix socket watch on Windows

2022-09-06 Thread Clément Chigot
> > > I checked your patch, what you did seems to be something one would > > > naturally write, but what is currently in the QEMU sources seems to be > > > written intentionally. > > > > > > +Paolo Bonzini , you are the one who implemented the socket watch on > > > Windows. Could you please help an

Re: [PATCH 49/51] io/channel-watch: Fix socket watch on Windows

2022-09-06 Thread Bin Meng
Hi Clément, On Tue, Sep 6, 2022 at 3:41 PM Clément Chigot wrote: > > Hi Bin, > > > On Mon, Sep 5, 2022 at 4:10 PM Clément Chigot wrote: > > > > > > Hi all, > > > > > > I did reach the same issue while trying to connect a gdb to qemu on > > > Windows hosts. Some inputs send by gdb aren't getting

Re: [PATCH 49/51] io/channel-watch: Fix socket watch on Windows

2022-09-06 Thread Clément Chigot
Hi Bin, > On Mon, Sep 5, 2022 at 4:10 PM Clément Chigot wrote: > > > > Hi all, > > > > I did reach the same issue while trying to connect a gdb to qemu on > > Windows hosts. Some inputs send by gdb aren't getting correctly pulled, > > they will be retrieved only once g_poll times out. > > > > As

Re: [PATCH 49/51] io/channel-watch: Fix socket watch on Windows

2022-09-06 Thread Bin Meng
Hi Clément, On Mon, Sep 5, 2022 at 4:10 PM Clément Chigot wrote: > > Hi all, > > I did reach the same issue while trying to connect a gdb to qemu on > Windows hosts. Some inputs send by gdb aren't getting correctly pulled, > they will be retrieved only once g_poll times out. > > As you explained

Re: [PATCH 49/51] io/channel-watch: Fix socket watch on Windows

2022-09-05 Thread Clément Chigot
Hi all, I did reach the same issue while trying to connect a gdb to qemu on Windows hosts. Some inputs send by gdb aren't getting correctly pulled, they will be retrieved only once g_poll times out. As you explained earlier, the issue, AFAICT, is that WSAEnumNetworkEvents will reset the internal

Re: [PATCH 49/51] io/channel-watch: Fix socket watch on Windows

2022-09-04 Thread Bin Meng
On Mon, Sep 5, 2022 at 2:04 PM Marc-André Lureau wrote: > > Hi > > On Sun, Sep 4, 2022 at 10:24 AM Bin Meng wrote: >> >> On Thu, Sep 1, 2022 at 8:58 PM Marc-André Lureau >> wrote: >> > >> > Hi >> > >> > On Wed, Aug 24, 2022 at 2:49 PM Bin Meng wrote: >> >> >> >> From: Bin Meng >> >> >> >> Rand

Re: [PATCH 49/51] io/channel-watch: Fix socket watch on Windows

2022-09-04 Thread Marc-André Lureau
Hi On Sun, Sep 4, 2022 at 10:24 AM Bin Meng wrote: > On Thu, Sep 1, 2022 at 8:58 PM Marc-André Lureau > wrote: > > > > Hi > > > > On Wed, Aug 24, 2022 at 2:49 PM Bin Meng wrote: > >> > >> From: Bin Meng > >> > >> Random failure was observed when running qtests on Windows due to > >> "Broken p

Re: [PATCH 49/51] io/channel-watch: Fix socket watch on Windows

2022-09-03 Thread Bin Meng
On Thu, Sep 1, 2022 at 8:58 PM Marc-André Lureau wrote: > > Hi > > On Wed, Aug 24, 2022 at 2:49 PM Bin Meng wrote: >> >> From: Bin Meng >> >> Random failure was observed when running qtests on Windows due to >> "Broken pipe" detected by qmp_fd_receive(). What happened is that >> the qtest execut

Re: [PATCH 49/51] io/channel-watch: Fix socket watch on Windows

2022-09-01 Thread Marc-André Lureau
Hi On Wed, Aug 24, 2022 at 2:49 PM Bin Meng wrote: > From: Bin Meng > > Random failure was observed when running qtests on Windows due to > "Broken pipe" detected by qmp_fd_receive(). What happened is that > the qtest executable sends testing data over a socket to the QEMU > under test but no r

[PATCH 49/51] io/channel-watch: Fix socket watch on Windows

2022-08-24 Thread Bin Meng
From: Bin Meng Random failure was observed when running qtests on Windows due to "Broken pipe" detected by qmp_fd_receive(). What happened is that the qtest executable sends testing data over a socket to the QEMU under test but no response is received. The errno of the recv() call from the qtest